From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1357807266.1806.72.camel@aeonflux> Subject: Re: [PATCH 8/8] Bluetooth: Fix sending incorrect new_settings for mgmt_set_powered From: Marcel Holtmann To: Johan Hedberg Cc: linux-bluetooth@vger.kernel.org Date: Thu, 10 Jan 2013 00:41:06 -0800 In-Reply-To: <1357738180-4128-9-git-send-email-johan.hedberg@gmail.com> References: <1357738180-4128-1-git-send-email-johan.hedberg@gmail.com> <1357738180-4128-9-git-send-email-johan.hedberg@gmail.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Johan, > The socket from which a mgmt_set_powered command was received should > only receive the command response but no new_settings event. > > The mgmt_powered() function which is used to handle the situation with > the HCI_AUTO_OFF flag tries to check for a pending command to know which > socket to skip the event for, but since the pending command hasn't been > added this will not happen. > > This patch fixes the issue by adding the pending command for the > HCI_AUTO_OFF case and thereby ensures that mgmt_powered() will skip the > right socket when sending the new_settings event, but still send the > proper response to the socket where the command came from. > > Signed-off-by: Johan Hedberg > --- > net/bluetooth/mgmt.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Acked-by: Marcel Holtmann Regards Marcel