Linux bluetooth development
 help / color / mirror / Atom feed
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ 08/13 v2] test: Adapt simple-player to the new API of MediaPlayer1
Date: Thu, 10 Jan 2013 15:37:13 +0200	[thread overview]
Message-ID: <1357825038-21970-8-git-send-email-luiz.dentz@gmail.com> (raw)
In-Reply-To: <1357825038-21970-1-git-send-email-luiz.dentz@gmail.com>

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

---
 test/simple-player | 62 ++++++++++++++++--------------------------------------
 1 file changed, 18 insertions(+), 44 deletions(-)

diff --git a/test/simple-player b/test/simple-player
index 3bfc485..e331c52 100755
--- a/test/simple-player
+++ b/test/simple-player
@@ -22,46 +22,36 @@ class Player(dbus.service.Object):
 						"org.freedesktop.DBus.Properties")
 
 			self.properties = prop.GetAll("org.bluez.MediaPlayer1")
-			self.metadata = mp.GetTrack()
 
 			bus.add_signal_receiver(self.properties_changed,
 				path = obj,
 				dbus_interface = "org.freedesktop.DBus.Properties",
 				signal_name = "PropertiesChanged")
-
-			bus.add_signal_receiver(self.track_changed,
-				path = obj,
-				dbus_interface ="org.bluez.MediaPlayer",
-				signal_name = "TrackChanged")
 		else:
+			track = dbus.Dictionary({
+					"Title" : "Title",
+					"Artist" : "Artist",
+					"Album" : "Album",
+					"Genre" : "Genre",
+					"NumberOfTracks" : dbus.UInt32(10),
+					"TrackNumber" : dbus.UInt32(1),
+					"Duration" : dbus.UInt32(10000) },
+					signature="sv")
+
 			self.properties = dbus.Dictionary({
 					"Equalizer" : "off",
 					"Repeat" : "off",
 					"Shuffle" : "off",
 					"Scan" : "off",
 					"Status" : "playing",
-					"Position" : dbus.UInt32(0) },
+					"Position" : dbus.UInt32(0),
+					"Track" : track },
 					signature="sv")
 
-			self.metadata = dbus.Dictionary({
-					"Title" : "Title",
-					"Artist" : "Artist",
-					"Album" : "Album",
-					"Genre" : "Genre",
-					"NumberOfTracks" : dbus.UInt32(10),
-					"Track" : dbus.UInt32(1),
-					"Duration" : dbus.UInt32(10000) },
-					signature="sv")
 			handler = InputHandler(self)
 			gobject.io_add_watch(sys.stdin, gobject.IO_IN,
 							handler.handle)
 
-	@dbus.service.method("org.bluez.MediaPlayer1",
-					in_signature="", out_signature="")
-	def Release(self):
-		print("Release")
-		mainloop.quit()
-
 	@dbus.service.method("org.freedesktop.DBus.Properties",
 					in_signature="ssv", out_signature="")
 	def Set(self, interface, key, value):
@@ -79,15 +69,6 @@ class Player(dbus.service.Object):
 		"""
 		pass
 
-	@dbus.service.signal("org.bluez.MediaPlayer1", signature="a{sv}")
-	def TrackChanged(self, metadata):
-		"""TrackChanged(metadata)
-
-		Send a TrackChanged signal. 'metadata' parameter is a dictionary,
-		with values as defined in doc/media-api.txt.
-		"""
-		pass
-
 	def help(self, func):
 		help(self.__class__.__dict__[func])
 
@@ -96,14 +77,8 @@ class Player(dbus.service.Object):
 
 		self.PropertiesChanged(interface, properties, invalidated)
 
-	def track_changed(self, metadata):
-		print("track_changed(%s)" % (metadata))
-
-		self.TrackChanged(metadata)
-
 class InputHandler:
-	commands = { 'TrackChanged': '(metadata)',
-			'PropertiesChanged': '(interface, properties)',
+	commands = { 'PropertiesChanged': '(interface, properties)',
 			'help': '(cmd)' }
 	def __init__(self, player):
 		self.player = player
@@ -112,7 +87,8 @@ class InputHandler:
 			print('\t', cmd, self.commands[cmd], sep='')
 
 		print("\nUse python syntax to pass arguments to available methods.\n" \
-                "E.g.: TrackChanged({'Title': 'My title', 'Album': 'my album' })")
+                "E.g.: PropertiesChanged({'Track' : {'Title': 'My title', \
+		'Album': 'my album' }})")
 		self.prompt()
 
 	def prompt(self):
@@ -160,11 +136,9 @@ if __name__ == '__main__':
 	else:
 		player.set_object()
 
-	print('Register media player with:\n\tProperties: %s\n\tMetadata: %s' \
-					% (player.properties, player.metadata))
-
+	print('Register media player with:\n\tProperties: %s' \
+						% (player.properties))
 
-	media.RegisterPlayer(dbus.ObjectPath(path), player.properties,
-							player.metadata)
+	media.RegisterPlayer(dbus.ObjectPath(path), player.properties)
 
 	mainloop.run()
-- 
1.8.0.1


  parent reply	other threads:[~2013-01-10 13:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-10 13:37 [PATCH BlueZ 01/13 v2] media-api: Add playback control methods to MediaPlayer1 Luiz Augusto von Dentz
2013-01-10 13:37 ` [PATCH BlueZ 02/13 v2] player: Remove GetTrack and TrackChanged Luiz Augusto von Dentz
2013-01-10 13:37 ` [PATCH BlueZ 03/13 v2] player: Add support for button controls Luiz Augusto von Dentz
2013-01-10 13:37 ` [PATCH BlueZ 04/13 v2] player: Fix documentation to use TrackNumber in track metadata Luiz Augusto von Dentz
2013-01-10 13:37 ` [PATCH BlueZ 05/13 v2] AVRCP: Always create a controller player even for version 1.0 Luiz Augusto von Dentz
2013-01-10 13:37 ` [PATCH BlueZ 06/13 v2] player: Add Device property Luiz Augusto von Dentz
2013-01-10 13:37 ` [PATCH BlueZ 07/13 v2] media: Adapt RegisterPlayer to changes in MediaPlayer1 Luiz Augusto von Dentz
2013-01-10 13:37 ` Luiz Augusto von Dentz [this message]
2013-01-10 13:37 ` [PATCH BlueZ 09/13 v2] tools: Adapt mpris-player to new API of MediaPlayer1 Luiz Augusto von Dentz
2013-01-10 13:37 ` [PATCH BlueZ 10/13 v2] media-api: Change RegisterPlayer to use MPRIS spec Luiz Augusto von Dentz
2013-01-10 13:37 ` [PATCH BlueZ 11/13 v2] test: Update test-player to register using MPRIS interface Luiz Augusto von Dentz
2013-01-10 13:37 ` [PATCH BlueZ 12/13 v2] media: Implement new RegisterPlayer API Luiz Augusto von Dentz
2013-01-10 13:37 ` [PATCH BlueZ 13/13 v2] tools: Update mpris-player to register using MPRIS interface Luiz Augusto von Dentz
2013-01-10 16:02   ` Anderson Lizardo
2013-01-10 16:56     ` Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1357825038-21970-8-git-send-email-luiz.dentz@gmail.com \
    --to=luiz.dentz@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox