* [PATCH BlueZ v2] build: Fix using DBusBasicValue
@ 2013-01-10 16:59 Luiz Augusto von Dentz
2013-01-10 23:51 ` Marcel Holtmann
0 siblings, 1 reply; 2+ messages in thread
From: Luiz Augusto von Dentz @ 2013-01-10 16:59 UTC (permalink / raw)
To: linux-bluetooth
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
DBusBasicValue needs a more recent libdbus so use const void * instead
---
v2: Fix all places
tools/mpris-player.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/mpris-player.c b/tools/mpris-player.c
index de66f97..246791a 100644
--- a/tools/mpris-player.c
+++ b/tools/mpris-player.c
@@ -151,7 +151,6 @@ static int parse_metadata_entry(DBusMessageIter *entry, const char *key,
DBusMessageIter *metadata)
{
DBusMessageIter var;
- DBusBasicValue value;
int type;
printf("metadata %s found\n", key);
@@ -181,6 +180,8 @@ static int parse_metadata_entry(DBusMessageIter *entry, const char *key,
dict_append_array(metadata, key, DBUS_TYPE_STRING, &values, i);
dbus_free(values);
} else if (dbus_type_is_basic(type)) {
+ const void *value;
+
dbus_message_iter_get_basic(&var, &value);
dict_append_entry(metadata, key, type, &value);
} else
@@ -312,7 +313,7 @@ static int parse_property(DBusConnection *conn, const char *path,
DBusMessageIter *properties)
{
DBusMessageIter var;
- DBusBasicValue value;
+ const void *value;
int type;
printf("property %s found\n", key);
--
1.8.0.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH BlueZ v2] build: Fix using DBusBasicValue
2013-01-10 16:59 [PATCH BlueZ v2] build: Fix using DBusBasicValue Luiz Augusto von Dentz
@ 2013-01-10 23:51 ` Marcel Holtmann
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2013-01-10 23:51 UTC (permalink / raw)
To: Luiz Augusto von Dentz; +Cc: linux-bluetooth
Hi Luiz,
> DBusBasicValue needs a more recent libdbus so use const void * instead
> ---
> v2: Fix all places
>
> tools/mpris-player.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
I changed the subject to tools: prefix since this is not build system
details. Otherwise, patch has been applied.
Regards
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-10 23:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-10 16:59 [PATCH BlueZ v2] build: Fix using DBusBasicValue Luiz Augusto von Dentz
2013-01-10 23:51 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).