From: Marcel Holtmann <marcel@holtmann.org>
To: Johan Hedberg <johan.hedberg@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/4] Bluetooth: Add a new workqueue for hci_request operations
Date: Mon, 14 Jan 2013 12:42:27 -0800 [thread overview]
Message-ID: <1358196147.1806.106.camel@aeonflux> (raw)
In-Reply-To: <1358195633-29303-2-git-send-email-johan.hedberg@gmail.com>
Hi Johan,
> The hci_request function is blocking and cannot be called through the
> usual per-HCI device workqueue (hdev->workqueue). While hci_request is
> in progress any other work from que queue, including sending HCI
no idea what a que queue is ;)
> commands to the controller would be blocked and eventually cause the
> hci_request call to time out.
>
> This patch adds a second workqueue to be used by operations needing
> hci_request and thereby avoiding issues with blocking other workqueue
> users.
>
> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
> ---
> include/net/bluetooth/hci_core.h | 1 +
> net/bluetooth/hci_core.c | 11 +++++++++++
> 2 files changed, 12 insertions(+)
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Regards
Marcel
next prev parent reply other threads:[~2013-01-14 20:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 20:33 [PATCH 0/4] Bluetooth: Fix workqueue related issues Johan Hedberg
2013-01-14 20:33 ` [PATCH 1/4] Bluetooth: Add a new workqueue for hci_request operations Johan Hedberg
2013-01-14 20:42 ` Marcel Holtmann [this message]
2013-01-14 20:33 ` [PATCH 2/4] Bluetooth: Use req_workqueue " Johan Hedberg
2013-01-14 20:43 ` Marcel Holtmann
2013-01-14 20:33 ` [PATCH 3/4] Bluetooth: Fix using system-global workqueue when not necessary Johan Hedberg
2013-01-14 20:44 ` Marcel Holtmann
2013-01-18 5:07 ` Gustavo Padovan
2013-01-14 20:33 ` [PATCH 4/4] Bluetooth: Fix write_scan_enable when HCI_AUTO_OFF is set Johan Hedberg
2013-01-15 1:06 ` Anderson Lizardo
2013-01-16 0:36 ` [PATCH 0/4] Bluetooth: Fix workqueue related issues Mat Martineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358196147.1806.106.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).