From: Marcel Holtmann <marcel@holtmann.org>
To: "Kling, Andreas" <Andreas.Kling@peiker.de>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: bluez: atomic operations
Date: Wed, 16 Jan 2013 21:25:37 -0800 [thread overview]
Message-ID: <1358400337.3059.11.camel@aeonflux> (raw)
In-Reply-To: <sig.6728472516.B3F251FD87EC894A88C2221EEEBDF54807096F7F3B@Exchange>
Hi Andy,
> using gcc atomic buildins breaks support for older gcc/platforms.
>
> src/bluetoothd-adapter.o: In function `btd_adapter_unref':
> adapter.c:(.text+0x63f8): undefined reference to `__sync_sub_and_fetch_4'
>
> I suggest to use glib g_atomic_* group of functions.
> They fall back to traditional locking if buildins are not available.
the GLib atomic API functions are not really stable. The GLib people for
some reason decided to break their own API/ABI guarantee. So we moved
away from using them. And I have no intention to get back to them.
Long term, we are moving away from GLib and want to switch to ELL. So
that means gcc atomics are required. My advise would be to get a modern
platform and not rely on workarounds.
Regards
Marcel
next prev parent reply other threads:[~2013-01-17 5:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 11:02 bluez: atomic operations Kling, Andreas
2013-01-17 5:25 ` Marcel Holtmann [this message]
2013-01-18 12:51 ` Kling, Andreas
[not found] <B3F251FD87EC894A88C2221EEEBDF54807096F7F3B@Exchange>
2013-01-16 11:12 ` Kling, Andreas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358400337.3059.11.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=Andreas.Kling@peiker.de \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox