Re: [PATCH 1/5] Bluetooth: Add option for SCO socket mode

[Marcel Holtmann <marcel@holtmann.org>]

Hi Fred,

> This patch extends the current SCO socket option to add a 'mode' field. This
> field is intended to choose data type at runtime. Current modes are CVSD and
> transparent SCO, but adding new modes could allow support for CSA2 and fine
> tuning a sco connection, for example latency, bandwith, voice setting. Incoming
> connections will be setup during defered setup. Outgoing connections have to
> be setup before connect(). The selected type is stored in the sco socket info.
> This patch declares needed members and implements getsockopt().
> ---
>  include/net/bluetooth/sco.h |   20 ++++++++++++++++++++
>  net/bluetooth/sco.c         |    3 +++
>  2 files changed, 23 insertions(+)
> 
> diff --git a/include/net/bluetooth/sco.h b/include/net/bluetooth/sco.h
> index 1e35c43..bc5d3d6 100644
> --- a/include/net/bluetooth/sco.h
> +++ b/include/net/bluetooth/sco.h
> @@ -41,8 +41,27 @@ struct sockaddr_sco {
>  
>  /* SCO socket options */
>  #define SCO_OPTIONS	0x01
> +
> +#define SCO_MODE_CVSD		0x00
> +#define SCO_MODE_TRANSPARENT	0x01
> +#define SCO_MODE_ENHANCED	0x02
> +

I do not like this enhanced magic. How is this suppose to work? And it
is also not explained in the commit message. Or used in this patch.

Regards

Marcel