From: Johan Hedberg <johan.hedberg@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH 05/10 v2] Bluetooth: Check for valid key->authenticated value for LTKs
Date: Sun, 20 Jan 2013 14:27:17 +0200 [thread overview]
Message-ID: <1358684842-4441-6-git-send-email-johan.hedberg@gmail.com> (raw)
In-Reply-To: <1358684842-4441-1-git-send-email-johan.hedberg@gmail.com>
From: Johan Hedberg <johan.hedberg@intel.com>
This patch adds necessary checks for the two allowed values of the
authenticated parameter of each Long Term Key, i.e. 0x00 and 0x01. If
any other value is encountered the valid response is to return invalid
params to user space.
Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
---
net/bluetooth/mgmt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index cd75899..bc04c44 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -2703,6 +2703,8 @@ done:
static bool ltk_is_valid(struct mgmt_ltk_info *key)
{
+ if (key->authenticated != 0x00 && key->authenticated != 0x01)
+ return false;
if (key->master != 0x00 && key->master != 0x01)
return false;
return true;
--
1.7.10.4
next prev parent reply other threads:[~2013-01-20 12:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-20 12:27 [PATCH 00/10 v2] Bluetooth: Fix more mgmt parameter checks Johan Hedberg
2013-01-20 12:27 ` [PATCH 01/10 v2] Bluetooth: Fix checking for correct mgmt_load_link_keys parameters Johan Hedberg
2013-01-20 12:27 ` [PATCH 02/10 v2] Bluetooth: Fix returning proper mgmt status for Load LTKs Johan Hedberg
2013-01-20 12:27 ` [PATCH 03/10 v2] Bluetooth: Fix checking for proper key->master value in " Johan Hedberg
2013-01-20 12:27 ` [PATCH 04/10 v2] Bluetooth: Refactor valid LTK data testing into its own function Johan Hedberg
2013-01-20 12:27 ` Johan Hedberg [this message]
2013-01-20 12:27 ` [PATCH 06/10 v2] Bluetooth: Add helper functions for testing bdaddr types Johan Hedberg
2013-01-20 12:27 ` [PATCH 07/10 v2] Bluetooth: Fix checking for valid address type values in mgmt commands Johan Hedberg
2013-01-20 12:27 ` [PATCH 08/10 v2] Bluetooth: Fix checking for valid disconnect parameters in unpair_device Johan Hedberg
2013-01-20 12:27 ` [PATCH 09/10 v2] Bluetooth: Fix returning proper cmd_complete for mgmt_disconnect Johan Hedberg
2013-01-20 12:27 ` [PATCH 10/10 v2] Bluetooth: Fix returning proper cmd_complete for mgmt_block/unblock Johan Hedberg
2013-01-23 4:07 ` Gustavo Padovan
2013-01-22 10:45 ` [PATCH 00/10 v2] Bluetooth: Fix more mgmt parameter checks Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358684842-4441-6-git-send-email-johan.hedberg@gmail.com \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox