From: Marcel Holtmann <marcel@holtmann.org>
To: Andre Guedes <andre.guedes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] Bluetooth: Fix L2CAP socket shutdown for LE connections
Date: Sat, 26 Jan 2013 04:28:22 +0100 [thread overview]
Message-ID: <1359170902.16748.6.camel@aeonflux> (raw)
In-Reply-To: <1359148426-22271-1-git-send-email-andre.guedes@openbossa.org>
Hi Andre,
> During the L2CAP socket shutdown, the LE connection is not terminated
> as expected. This bug can be reproduced using l2test tool. Once the
> LE connection is established, kill l2test and the LE connection will
> not terminate.
>
> This patch fixes hci_conn_disconnect function so it is able to
> terminate LE connections.
>
> Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
> ---
> net/bluetooth/hci_conn.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
> index 25bfce0..0492949 100644
> --- a/net/bluetooth/hci_conn.c
> +++ b/net/bluetooth/hci_conn.c
> @@ -250,6 +250,7 @@ static void hci_conn_disconnect(struct hci_conn *conn)
>
> switch (conn->type) {
> case ACL_LINK:
> + case LE_LINK:
> hci_acl_disconn(conn, reason);
> break;
> case AMP_LINK:
I am wondering if we are not missing SCO_LINK here either.
Regards
Marcel
next prev parent reply other threads:[~2013-01-26 3:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 21:13 [PATCH 1/2] Bluetooth: Fix L2CAP socket shutdown for LE connections Andre Guedes
2013-01-25 21:13 ` [PATCH 2/2] Bluetooth: Rename hci_acl_disconn Andre Guedes
2013-01-26 3:30 ` Marcel Holtmann
2013-01-26 3:28 ` Marcel Holtmann [this message]
2013-01-28 18:17 ` [PATCH 1/2] Bluetooth: Fix L2CAP socket shutdown for LE connections Andre Guedes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359170902.16748.6.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=andre.guedes@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox