linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH 1/9 v3] Bluetooth: Store UUIDs in the same order that they were added
Date: Sat, 26 Jan 2013 12:08:36 +0200	[thread overview]
Message-ID: <1359194924-3151-2-git-send-email-johan.hedberg@gmail.com> (raw)
In-Reply-To: <1359194924-3151-1-git-send-email-johan.hedberg@gmail.com>

From: Johan Hedberg <johan.hedberg@intel.com>

We should be encoding UUIDs to the EIR data in the same order that they
were added to the kernel, i.e. each UUID should be added to the end of
the UUIDs list. This patch fixes the issue by using list_add_tail
instead of list_add for storing the UUIDs.

Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
---
 net/bluetooth/mgmt.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index e7f944f..4fd45a3 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -1330,7 +1330,7 @@ static int add_uuid(struct sock *sk, struct hci_dev *hdev, void *data, u16 len)
 	memcpy(uuid->uuid, cp->uuid, 16);
 	uuid->svc_hint = cp->svc_hint;
 
-	list_add(&uuid->list, &hdev->uuids);
+	list_add_tail(&uuid->list, &hdev->uuids);
 
 	err = update_class(hdev);
 	if (err < 0)
-- 
1.7.10.4


  reply	other threads:[~2013-01-26 10:08 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-26 10:08 [PATCH 0/9 v3] Bluetooth: Add 32 and 128 bit EIR UUID support Johan Hedberg
2013-01-26 10:08 ` Johan Hedberg [this message]
2013-01-26 17:03   ` [PATCH 1/9 v3] Bluetooth: Store UUIDs in the same order that they were added Marcel Holtmann
2013-01-26 10:08 ` [PATCH 2/9 v3] Bluetooth: Simplify UUIDs clearing code Johan Hedberg
2013-01-26 17:03   ` Marcel Holtmann
2013-01-26 10:08 ` [PATCH 3/9 v3] Bluetooth: Keep track of UUID type upon addition Johan Hedberg
2013-01-26 17:07   ` Marcel Holtmann
2013-01-26 10:08 ` [PATCH 4/9 v3] Bluetooth: Simplify UUID removal code Johan Hedberg
2013-01-26 17:09   ` Marcel Holtmann
2013-01-26 10:08 ` [PATCH 5/9 v3] Bluetooth: Simplify UUID16 list generation for EIR Johan Hedberg
2013-01-26 17:11   ` Marcel Holtmann
2013-01-26 10:08 ` [PATCH 6/9 v3] Bluetooth: Remove useless eir_len variable from EIR creation Johan Hedberg
2013-01-26 17:12   ` Marcel Holtmann
2013-01-26 10:08 ` [PATCH 7/9 v3] Bluetooth: Refactor UUID-16 list generation into its own function Johan Hedberg
2013-01-26 17:13   ` Marcel Holtmann
2013-01-26 10:08 ` [PATCH 8/9 v3] Bluetooth: Add support for 32-bit UUIDs in EIR data Johan Hedberg
2013-01-26 17:14   ` Marcel Holtmann
2013-01-26 10:08 ` [PATCH 9/9 v3] Bluetooth: Add support for 128-bit " Johan Hedberg
2013-01-26 17:15   ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1359194924-3151-2-git-send-email-johan.hedberg@gmail.com \
    --to=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).