Linux bluetooth development
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH BlueZ] AVRCP: Handler player features as a byte array
Date: Mon, 04 Feb 2013 11:27:32 +0200	[thread overview]
Message-ID: <1359970052.6873.23.camel@aeonflux> (raw)
In-Reply-To: <CABBYNZ+u55P_TVMUEcfwJkc9KpT2GVnYjZzG6RuFVfWhReGpsg@mail.gmail.com>

Hi Luiz,

> >> --- a/profiles/audio/player.c
> >> +++ b/profiles/audio/player.c
> >> @@ -67,7 +67,7 @@ struct media_player {
> >>       char                    *name;          /* Player name */
> >>       char                    *type;          /* Player type */
> >>       char                    *subtype;       /* Player subtype */
> >> -     uint64_t                features[2];    /* Player features */
> >> +     uint8_t                 *features;      /* Player features */
> >
> > Why not just have this as features[16] here as well so you don't need to
> > do g_memdup and g_free?
> 
> I was planning to have a NULL check if the features are valid.

actually I like to decrease the number of extra memory allocations. So
what benefit is the test for features giving you actually.

Regards

Marcel



  reply	other threads:[~2013-02-04  9:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-03 20:55 [PATCH BlueZ] AVRCP: Handler player features as a byte array Luiz Augusto von Dentz
2013-02-04  8:30 ` Johan Hedberg
2013-02-04  8:34   ` Luiz Augusto von Dentz
2013-02-04  9:27     ` Marcel Holtmann [this message]
2013-02-04  9:42       ` Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1359970052.6873.23.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox