linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Szymon Janc <szymon@janc.net.pl>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 2/2] adapter: Set default adapter id sooner
Date: Wed, 06 Feb 2013 09:57:44 +0200	[thread overview]
Message-ID: <1360137464.15783.7.camel@aeonflux> (raw)
In-Reply-To: <1360098656-12488-2-git-send-email-szymon@janc.net.pl>

Hi Szymon,

> When first adapter is registered set it as default before probing
> drivers or profiles as those might depend on that e.g. hostname.
> 
> This fix hostname plugin setting default adapter name to 'foo #1'
> instead of 'foo' if pretty hostname was received before probing
> adapter drivers.

you find an issue that I meant to fix, but never got around so far. So I
do not like the magic default_adapter_id global variable.

I would prefer if we add a is_default or similar variable to btd_adapter
and make it change if one adapter goes away.

Regards

Marcel



  reply	other threads:[~2013-02-06  7:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-05 21:10 [PATCH 1/2] hostname: Fallback to static hostname if pretty hostname is not set Szymon Janc
2013-02-05 21:10 ` [PATCH 2/2] adapter: Set default adapter id sooner Szymon Janc
2013-02-06  7:57   ` Marcel Holtmann [this message]
2013-02-06 19:54     ` Szymon Janc
2013-02-06  7:44 ` [PATCH 1/2] hostname: Fallback to static hostname if pretty hostname is not set Marcel Holtmann
2013-02-06 20:29   ` Szymon Janc
2013-02-07  8:31     ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1360137464.15783.7.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=szymon@janc.net.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).