From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ 1/3 v2] audio: Remove profile enabling/disabling logic
Date: Thu, 7 Mar 2013 11:41:22 +0200 [thread overview]
Message-ID: <1362649284-24335-1-git-send-email-luiz.dentz@gmail.com> (raw)
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
This should be handle by the core for all profiles
---
v2: Match only local_uuid to avoid end up disabling both roles whenever one
role is disabled.
profiles/audio/audio.conf | 4 ---
profiles/audio/manager.c | 62 ++++++-----------------------------------------
2 files changed, 8 insertions(+), 58 deletions(-)
diff --git a/profiles/audio/audio.conf b/profiles/audio/audio.conf
index f556610..067b3fc 100644
--- a/profiles/audio/audio.conf
+++ b/profiles/audio/audio.conf
@@ -6,7 +6,3 @@
# Switch to master role for incoming connections (defaults to true)
#Master=true
-
-# If we want to disable support for specific services
-# Defaults to supporting the services: Sink, Control
-#Disable=Source
diff --git a/profiles/audio/manager.c b/profiles/audio/manager.c
index 934227e..42a2b58 100644
--- a/profiles/audio/manager.c
+++ b/profiles/audio/manager.c
@@ -70,12 +70,6 @@
static GKeyFile *config = NULL;
static GSList *devices = NULL;
-static struct enabled_interfaces enabled = {
- .sink = TRUE,
- .source = FALSE,
- .control = TRUE,
-};
-
static struct audio_device *get_audio_dev(struct btd_device *device)
{
return manager_get_audio_device(device, TRUE);
@@ -410,47 +404,12 @@ void audio_control_disconnected(struct btd_device *dev, int err)
int audio_manager_init(GKeyFile *conf)
{
- char **list;
- int i;
-
- if (!conf)
- goto proceed;
-
- config = conf;
-
- list = g_key_file_get_string_list(config, "General", "Enable",
- NULL, NULL);
- for (i = 0; list && list[i] != NULL; i++) {
- if (g_str_equal(list[i], "Sink"))
- enabled.sink = TRUE;
- else if (g_str_equal(list[i], "Source"))
- enabled.source = TRUE;
- else if (g_str_equal(list[i], "Control"))
- enabled.control = TRUE;
- }
- g_strfreev(list);
-
- list = g_key_file_get_string_list(config, "General", "Disable",
- NULL, NULL);
- for (i = 0; list && list[i] != NULL; i++) {
- if (g_str_equal(list[i], "Sink"))
- enabled.sink = FALSE;
- else if (g_str_equal(list[i], "Source"))
- enabled.source = FALSE;
- else if (g_str_equal(list[i], "Control"))
- enabled.control = FALSE;
- }
- g_strfreev(list);
+ if (conf)
+ config = conf;
-proceed:
- if (enabled.source)
- btd_profile_register(&a2dp_source_profile);
-
- if (enabled.sink)
- btd_profile_register(&a2dp_sink_profile);
-
- if (enabled.control)
- btd_profile_register(&avrcp_profile);
+ btd_profile_register(&a2dp_source_profile);
+ btd_profile_register(&a2dp_sink_profile);
+ btd_profile_register(&avrcp_profile);
btd_register_adapter_driver(&media_driver);
@@ -464,14 +423,9 @@ void audio_manager_exit(void)
config = NULL;
}
- if (enabled.source)
- btd_profile_unregister(&a2dp_source_profile);
-
- if (enabled.sink)
- btd_profile_unregister(&a2dp_sink_profile);
-
- if (enabled.control)
- btd_profile_unregister(&avrcp_profile);
+ btd_profile_unregister(&a2dp_source_profile);
+ btd_profile_unregister(&a2dp_sink_profile);
+ btd_profile_unregister(&avrcp_profile);
btd_unregister_adapter_driver(&media_driver);
}
--
1.8.1.4
next reply other threads:[~2013-03-07 9:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 9:41 Luiz Augusto von Dentz [this message]
2013-03-07 9:41 ` [PATCH BlueZ 2/3 v2] audio: Fix not using opposite role for local servers Luiz Augusto von Dentz
2013-03-07 9:41 ` [PATCH BlueZ 3/3 v2] core: Add DisableProfiles entry to main.conf Luiz Augusto von Dentz
2013-03-07 13:54 ` [PATCH BlueZ 1/3 v2] audio: Remove profile enabling/disabling logic Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362649284-24335-1-git-send-email-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox