Linux bluetooth development
 help / color / mirror / Atom feed
From: Alex Deymo <deymo@chromium.org>
To: linux-bluetooth@vger.kernel.org
Cc: marcel@holtmann.org, keybuk@chromium.org,
	Alex Deymo <deymo@chromium.org>
Subject: [PATCH v2 0/8] Autopair plugin, with some extensions.
Date: Fri, 12 Apr 2013 16:28:30 -0700	[thread overview]
Message-ID: <1365809318-17775-1-git-send-email-deymo@chromium.org> (raw)

Hi,

This patch set includes a few changes mentioned in the mailing list
and a new functionality for dumb keyboards (last 2 commits).

"count" changed to "attempt". I agree that "attempt" is a better name.
With this change, attempt is now started at 1, so the first attempt of
a given plugin will be called with attempt==1. This also changes the
variable type to an unsinged version since it is not supposed to store
a negative number.

Added a timer to measure the pairing duration of the last attempt. This
is a great information to the autopair plugin to identify the cause of a
pairing failure. If a keyboard rejects the provided pincode in very short
time (less than 500ms) it means that the provided random pincode wasn't
the right code and is likelly that any random pincode will be rejected.
It turns out that those keyboards have a fixed pincode of "0000".

Please take another look.
Thanks,
Alex.

Alex Deymo (8):
  core: Convert the pincode callback to an interable list.
  plugins: Extend the pin code callback with the call number
  core: Add support for retrying a bonding
  core: retry bonding attempt until the iterator reachs the end.
  core: Add device_get_class to the public interface.
  autopair: Add the autopair plugin.
  core: Expose the last bonding attempt timeout on retry
  autopair: Try a fixed pincode for keyboards rejecting random codes

 Makefile.plugins   |   3 +
 plugins/autopair.c | 165 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 plugins/wiimote.c  |   7 ++-
 src/adapter.c      | 163 ++++++++++++++++++++++++++++++++++++++++++++--------
 src/adapter.h      |  10 +++-
 src/device.c       | 134 ++++++++++++++++++++++++++++++++++++++++++-
 src/device.h       |   7 +++
 7 files changed, 462 insertions(+), 27 deletions(-)
 create mode 100644 plugins/autopair.c

-- 
1.8.1.3


             reply	other threads:[~2013-04-12 23:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-12 23:28 Alex Deymo [this message]
2013-04-12 23:28 ` [PATCH v2 1/8] core: Convert the pincode callback to an interable list Alex Deymo
2013-04-23  7:50   ` Johan Hedberg
2013-04-12 23:28 ` [PATCH v2 2/8] plugins: Extend the pin code callback with the call number Alex Deymo
2013-04-12 23:28 ` [PATCH v2 3/8] core: Add support for retrying a bonding Alex Deymo
2013-04-12 23:28 ` [PATCH v2 4/8] core: retry bonding attempt until the iterator reachs the end Alex Deymo
2013-04-12 23:28 ` [PATCH v2 5/8] core: Add device_get_class to the public interface Alex Deymo
2013-04-12 23:28 ` [PATCH v2 6/8] autopair: Add the autopair plugin Alex Deymo
2013-04-12 23:28 ` [PATCH v2 7/8] core: Expose the last bonding attempt duration on retry Alex Deymo
2013-04-12 23:28 ` [PATCH v2 8/8] autopair: Try a fixed pincode for keyboards rejecting random codes Alex Deymo
2013-04-22 17:51 ` [PATCH v2 0/8] Autopair plugin, with some extensions Alex Deymo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365809318-17775-1-git-send-email-deymo@chromium.org \
    --to=deymo@chromium.org \
    --cc=keybuk@chromium.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox