[PATCH BlueZ 1/2] test: Remove commented out code from simple-agent

[PATCH BlueZ 1/2] test: Remove commented out code from simple-agent

[Anderson Lizardo]

---
 test/simple-agent |    3 ---
 1 file changed, 3 deletions(-)

diff --git a/test/simple-agent b/test/simple-agent
index 854e1af..64b2ca8 100755
--- a/test/simple-agent
+++ b/test/simple-agent
@@ -176,6 +176,3 @@ if __name__ == '__main__':
 		manager.RequestDefaultAgent(path)
 
 	mainloop.run()
-
-	#adapter.UnregisterAgent(path)
-	#print("Agent unregistered")
-- 
1.7.9.5

[PATCH BlueZ 2/2] test: Use existing AGENT_PATH variable on simple-agent

[Anderson Lizardo]

---
 test/simple-agent |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/test/simple-agent b/test/simple-agent
index 64b2ca8..5475770 100755
--- a/test/simple-agent
+++ b/test/simple-agent
@@ -148,14 +148,13 @@ if __name__ == '__main__':
 	if options.capability:
 		capability  = options.capability
 
-	path = "/test/agent"
-	agent = Agent(bus, path)
+	agent = Agent(bus, AGENT_PATH)
 
 	mainloop = GObject.MainLoop()
 
 	obj = bus.get_object(BUS_NAME, "/org/bluez");
 	manager = dbus.Interface(obj, "org.bluez.AgentManager1")
-	manager.RegisterAgent(path, capability)
+	manager.RegisterAgent(AGENT_PATH, capability)
 
 	print("Agent registered")
 
@@ -173,6 +172,6 @@ if __name__ == '__main__':
 								timeout=60000)
 		device_obj = device
 	else:
-		manager.RequestDefaultAgent(path)
+		manager.RequestDefaultAgent(AGENT_PATH)
 
 	mainloop.run()
-- 
1.7.9.5

Re: [PATCH BlueZ 1/2] test: Remove commented out code from simple-agent

[Marcel Holtmann]

Hi Anderson,

> ---
> test/simple-agent |    3 ---
> 1 file changed, 3 deletions(-)
> 
> diff --git a/test/simple-agent b/test/simple-agent
> index 854e1af..64b2ca8 100755
> --- a/test/simple-agent
> +++ b/test/simple-agent
> @@ -176,6 +176,3 @@ if __name__ == '__main__':
> 		manager.RequestDefaultAgent(path)
> 
> 	mainloop.run()
> -
> -	#adapter.UnregisterAgent(path)
> -	#print("Agent unregistered")

I would prefer if we remove the whole script. Does it provide anything that bluetoothctl is not providing?

Regards

Marcel

Re: [PATCH BlueZ 1/2] test: Remove commented out code from simple-agent

[Anderson Lizardo]

Hi Marcel,

On Thu, May 16, 2013 at 9:45 AM, Marcel Holtmann <marcel@holtmann.org> wrote:
>> --- a/test/simple-agent
>> +++ b/test/simple-agent
>> @@ -176,6 +176,3 @@ if __name__ == '__main__':
>>               manager.RequestDefaultAgent(path)
>>
>>       mainloop.run()
>> -
>> -     #adapter.UnregisterAgent(path)
>> -     #print("Agent unregistered")
>
> I would prefer if we remove the whole script. Does it provide anything that bluetoothctl is not providing?

I have nothing against it (and we can always improve bluetoothctl if
something is missing there), but this is a legacy script that some
distros seem to package and users have been relying on it as a simple
console agent. Maybe we should (somehow) advertise bluetoothctl more.

BTW, It seems that --timeout/-t option on simple-agent is totally ignored.

Regards,
-- 
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil

Re: [PATCH BlueZ 1/2] test: Remove commented out code from simple-agent

[Marcel Holtmann]

Hi Anderson,

>>> --- a/test/simple-agent
>>> +++ b/test/simple-agent
>>> @@ -176,6 +176,3 @@ if __name__ == '__main__':
>>>              manager.RequestDefaultAgent(path)
>>> 
>>>      mainloop.run()
>>> -
>>> -     #adapter.UnregisterAgent(path)
>>> -     #print("Agent unregistered")
>> 
>> I would prefer if we remove the whole script. Does it provide anything that bluetoothctl is not providing?
> 
> I have nothing against it (and we can always improve bluetoothctl if
> something is missing there), but this is a legacy script that some
> distros seem to package and users have been relying on it as a simple
> console agent. Maybe we should (somehow) advertise bluetoothctl more.
> 
> BTW, It seems that --timeout/-t option on simple-agent is totally ignored.

then lets just delete it. Distros should be shipping bluetoothctl anyway these days.

Regards

Marcel

Re: [PATCH BlueZ 1/2] test: Remove commented out code from simple-agent

[Luiz Augusto von Dentz]

Hi Marcel,

On Fri, May 17, 2013 at 8:15 AM, Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi Anderson,
>
>>>> --- a/test/simple-agent
>>>> +++ b/test/simple-agent
>>>> @@ -176,6 +176,3 @@ if __name__ == '__main__':
>>>>              manager.RequestDefaultAgent(path)
>>>>
>>>>      mainloop.run()
>>>> -
>>>> -     #adapter.UnregisterAgent(path)
>>>> -     #print("Agent unregistered")
>>>
>>> I would prefer if we remove the whole script. Does it provide anything that bluetoothctl is not providing?
>>
>> I have nothing against it (and we can always improve bluetoothctl if
>> something is missing there), but this is a legacy script that some
>> distros seem to package and users have been relying on it as a simple
>> console agent. Maybe we should (somehow) advertise bluetoothctl more.
>>
>> BTW, It seems that --timeout/-t option on simple-agent is totally ignored.
>
> then lets just delete it. Distros should be shipping bluetoothctl anyway these days.

Ultimately it is better to use bluetoothctl but it doesn't hurt to
have an example in python, but we should probably improve the
documentation about agent capabilities and IMO it should default to
"KeyboardDisplay" when no capability is given (agent on), right now I
think it does "" which maps to IO_CAPABILITY_DISPLAYYESNO.

--
Luiz Augusto von Dentz