From: "Frédéric Dalleau" <frederic.dalleau@linux.intel.com>
To: linux-bluetooth@vger.kernel.org
Cc: "Frédéric Dalleau" <frederic.dalleau@linux.intel.com>
Subject: [PATCH v7 5/8] Bluetooth: Use voice setting in incoming SCO connection
Date: Thu, 16 May 2013 19:34:02 +0200 [thread overview]
Message-ID: <1368725646-4593-6-git-send-email-frederic.dalleau@linux.intel.com> (raw)
In-Reply-To: <1368725646-4593-1-git-send-email-frederic.dalleau@linux.intel.com>
When an incoming SCO connection is requested, check the selected voice setting,
and reply appropriately. Voice setting should have been negotiated previously.
For example, in case of HFP, the codec is negotiated using AT commands on the
RFCOMM channel. This patch only changes replies for socket with defered setup
enabled.
Signed-off-by: Frédéric Dalleau <frederic.dalleau@linux.intel.com>
---
net/bluetooth/sco.c | 23 ++++++++++++++++++-----
1 file changed, 18 insertions(+), 5 deletions(-)
diff --git a/net/bluetooth/sco.c b/net/bluetooth/sco.c
index 7b4c3df..7881208 100644
--- a/net/bluetooth/sco.c
+++ b/net/bluetooth/sco.c
@@ -653,7 +653,7 @@ static int sco_sock_sendmsg(struct kiocb *iocb, struct socket *sock,
return err;
}
-static void sco_conn_defer_accept(struct hci_conn *conn)
+static void sco_conn_defer_accept(struct hci_conn *conn, int setting)
{
struct hci_dev *hdev = conn->hdev;
@@ -676,9 +676,22 @@ static void sco_conn_defer_accept(struct hci_conn *conn)
cp.tx_bandwidth = __constant_cpu_to_le32(0x00001f40);
cp.rx_bandwidth = __constant_cpu_to_le32(0x00001f40);
- cp.max_latency = __constant_cpu_to_le16(0xffff);
- cp.content_format = cpu_to_le16(hdev->voice_setting);
- cp.retrans_effort = 0xff;
+
+ switch (hci_sco_airmode(setting)) {
+ case SCO_AIRMODE_TRANSP:
+ if (conn->pkt_type & ESCO_2EV3)
+ cp.max_latency = __constant_cpu_to_le16(0x0008);
+ else
+ cp.max_latency = __constant_cpu_to_le16(0x000D);
+ cp.content_format = __constant_cpu_to_le16(SCO_AIRMODE_TRANSP);
+ cp.retrans_effort = 0x02;
+ break;
+ case SCO_AIRMODE_CVSD:
+ cp.max_latency = __constant_cpu_to_le16(0xffff);
+ cp.content_format = cpu_to_le16(setting);
+ cp.retrans_effort = 0xff;
+ break;
+ }
hci_send_cmd(hdev, HCI_OP_ACCEPT_SYNC_CONN_REQ,
sizeof(cp), &cp);
@@ -695,7 +708,7 @@ static int sco_sock_recvmsg(struct kiocb *iocb, struct socket *sock,
if (sk->sk_state == BT_CONNECT2 &&
test_bit(BT_SK_DEFER_SETUP, &bt_sk(sk)->flags)) {
- sco_conn_defer_accept(pi->conn->hcon);
+ sco_conn_defer_accept(pi->conn->hcon, pi->setting);
sk->sk_state = BT_CONFIG;
release_sock(sk);
--
1.7.9.5
next prev parent reply other threads:[~2013-05-16 17:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 17:33 [PATCH v7 0/8] sco: SCO socket option for voice_setting Frédéric Dalleau
2013-05-16 17:33 ` [PATCH v7 1/8] Bluetooth: Use hci_connect_sco directly Frédéric Dalleau
2013-05-16 17:33 ` [PATCH v7 2/8] Bluetooth: Remove unused mask parameter in sco_conn_defer_accept Frédéric Dalleau
2013-05-17 8:40 ` Marcel Holtmann
2013-05-16 17:34 ` [PATCH v7 3/8] Bluetooth: Add bluetooth socket voice option Frédéric Dalleau
2013-05-17 8:48 ` Marcel Holtmann
2013-05-16 17:34 ` [PATCH v7 4/8] Bluetooth: Constants and macro declaration for SCO airmode Frédéric Dalleau
2013-05-17 8:49 ` Marcel Holtmann
2013-05-16 17:34 ` Frédéric Dalleau [this message]
2013-05-17 8:51 ` [PATCH v7 5/8] Bluetooth: Use voice setting in incoming SCO connection Marcel Holtmann
2013-05-16 17:34 ` [PATCH v7 6/8] Bluetooth: Parameters for outgoing SCO connections Frédéric Dalleau
2013-05-17 8:55 ` Marcel Holtmann
2013-05-17 13:10 ` Vinicius Gomes
2013-05-16 17:34 ` [PATCH v7 7/8] Bluetooth: Fallback transparent SCO from T2 to T1 Frédéric Dalleau
2013-05-17 9:00 ` Marcel Holtmann
2013-05-16 17:34 ` [PATCH v7 8/8] Bluetooth: Add support for fallback between CVSD recommended settings Frédéric Dalleau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368725646-4593-6-git-send-email-frederic.dalleau@linux.intel.com \
--to=frederic.dalleau@linux.intel.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).