From: "Frédéric Dalleau" <frederic.dalleau@linux.intel.com>
To: linux-bluetooth@vger.kernel.org
Cc: "Frédéric Dalleau" <frederic.dalleau@linux.intel.com>
Subject: [PATCH v7 8/8] Bluetooth: Add support for fallback between CVSD recommended settings
Date: Thu, 16 May 2013 19:34:05 +0200 [thread overview]
Message-ID: <1368725646-4593-9-git-send-email-frederic.dalleau@linux.intel.com> (raw)
In-Reply-To: <1368725646-4593-1-git-send-email-frederic.dalleau@linux.intel.com>
When CVSD is requested and eSCO is supported, try to establish eSCO connection
using S3 settings. If it fails, fallback in sequence to S2, S1, D1, D0 settings.
These settings are described in Bluetooth HFP 1.6 specification p. 101.
Signed-off-by: Frédéric Dalleau <frederic.dalleau@linux.intel.com>
---
net/bluetooth/hci_conn.c | 19 +++++++++++++++----
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
index 8d71d73..f4aa8b2 100644
--- a/net/bluetooth/hci_conn.c
+++ b/net/bluetooth/hci_conn.c
@@ -42,6 +42,14 @@ static const struct sco_param sco_param_wideband[] = {
{ EDR_ESCO_MASK | ESCO_EV3, 0x0008, 0 },
};
+static const struct sco_param sco_param_cvsd[] = {
+ { EDR_ESCO_MASK & ~ESCO_2EV3, 0x000a, 1 },
+ { EDR_ESCO_MASK & ~ESCO_2EV3, 0x0007, 2 },
+ { EDR_ESCO_MASK | ESCO_EV3, 0x0007, 3 },
+ { EDR_ESCO_MASK | ESCO_HV3, 0xffff, 4 },
+ { EDR_ESCO_MASK | ESCO_HV1, 0xffff, 0 },
+};
+
static void hci_le_create_connection(struct hci_conn *conn)
{
struct hci_dev *hdev = conn->hdev;
@@ -212,10 +220,13 @@ void hci_setup_sync(struct hci_conn *conn, __u16 handle)
conn->fallback = param->next;
break;
case SCO_AIRMODE_CVSD:
- cp.pkt_type = cpu_to_le16(conn->pkt_type);
- cp.max_latency = __constant_cpu_to_le16(0xffff);
- cp.voice_setting = cpu_to_le16(hdev->voice_setting);
- cp.retrans_effort = 0xff;
+ param = &sco_param_cvsd[conn->fallback];
+ cp.pkt_type = __constant_cpu_to_le16(param->pkt_type);
+ cp.max_latency = __constant_cpu_to_le16(param->max_latency);
+ cp.voice_setting = __constant_cpu_to_le16(conn->setting);
+ cp.retrans_effort = 0x01;
+
+ conn->fallback = param->next;
break;
}
--
1.7.9.5
prev parent reply other threads:[~2013-05-16 17:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 17:33 [PATCH v7 0/8] sco: SCO socket option for voice_setting Frédéric Dalleau
2013-05-16 17:33 ` [PATCH v7 1/8] Bluetooth: Use hci_connect_sco directly Frédéric Dalleau
2013-05-16 17:33 ` [PATCH v7 2/8] Bluetooth: Remove unused mask parameter in sco_conn_defer_accept Frédéric Dalleau
2013-05-17 8:40 ` Marcel Holtmann
2013-05-16 17:34 ` [PATCH v7 3/8] Bluetooth: Add bluetooth socket voice option Frédéric Dalleau
2013-05-17 8:48 ` Marcel Holtmann
2013-05-16 17:34 ` [PATCH v7 4/8] Bluetooth: Constants and macro declaration for SCO airmode Frédéric Dalleau
2013-05-17 8:49 ` Marcel Holtmann
2013-05-16 17:34 ` [PATCH v7 5/8] Bluetooth: Use voice setting in incoming SCO connection Frédéric Dalleau
2013-05-17 8:51 ` Marcel Holtmann
2013-05-16 17:34 ` [PATCH v7 6/8] Bluetooth: Parameters for outgoing SCO connections Frédéric Dalleau
2013-05-17 8:55 ` Marcel Holtmann
2013-05-17 13:10 ` Vinicius Gomes
2013-05-16 17:34 ` [PATCH v7 7/8] Bluetooth: Fallback transparent SCO from T2 to T1 Frédéric Dalleau
2013-05-17 9:00 ` Marcel Holtmann
2013-05-16 17:34 ` Frédéric Dalleau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368725646-4593-9-git-send-email-frederic.dalleau@linux.intel.com \
--to=frederic.dalleau@linux.intel.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).