From: johannes.goede@oss.qualcomm.com
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org,
Ibrahim Abdelkader <iabdelka@qti.qualcomm.com>
Subject: Re: [1/2] Bluetooth: hci_sync: Clear HCI_CMD_PENDING when dropping the last request
Date: Tue, 11 Aug 2026 16:43:36 +0200 [thread overview]
Message-ID: <13692d14-6093-457c-bf39-42afd2d5f8a7@oss.qualcomm.com> (raw)
In-Reply-To: <CABBYNZKPA8UjfY0uo8cPE4BbxTRON-OgEpMuuHdwJ=br91H3Tw@mail.gmail.com>
Hi Luiz,
On 11-Aug-26 15:59, Luiz Augusto von Dentz wrote:
> Hi,
>
> On Tue, Aug 11, 2026 at 7:05 AM <johannes.goede@oss.qualcomm.com> wrote:
<snip>
>> I'm seeing the exact same failures in other CI runs from recent
>> patches, e.g. :
>>
>> https://lore.kernel.org/linux-bluetooth/20260808062541.3705446-1-zhangchen200426@163.com/T/#t
>>
>> So I'm assuming that these are pre-existing CI issues and
>> not caused by this patch.
>
> Yeah, don't worry about those, there is an issue found by sashiko that
> perhaps we need to address:
>
> https://sashiko.dev/#/patchset/20260811083730.71393-1-johannes.goede%40oss.qualcomm.com
Thank you for pointing that out.
The Sashiko suggestion to make the clearing of the flag unconditionally
(after freeing the skb if it is there) seems to make sense.
Shall I prepare a v2 with that change ?
Regards,
Hans
next prev parent reply other threads:[~2026-08-11 14:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 8:37 [PATCH 1/2] Bluetooth: hci_sync: Clear HCI_CMD_PENDING when dropping the last request Hans de Goede
2026-08-11 8:37 ` [PATCH 2/2] Bluetooth: hci_sync: Factor common cleanup code into a helper Hans de Goede
2026-08-11 9:22 ` [1/2] Bluetooth: hci_sync: Clear HCI_CMD_PENDING when dropping the last request bluez.test.bot
2026-08-11 11:02 ` johannes.goede
2026-08-11 13:59 ` Luiz Augusto von Dentz
2026-08-11 14:43 ` johannes.goede [this message]
2026-08-11 14:49 ` Luiz Augusto von Dentz
2026-08-11 20:10 ` [PATCH 1/2] " patchwork-bot+bluetooth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13692d14-6093-457c-bf39-42afd2d5f8a7@oss.qualcomm.com \
--to=johannes.goede@oss.qualcomm.com \
--cc=iabdelka@qti.qualcomm.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox