From: Mikel Astiz <mikel.astiz.oss@gmail.com>
To: linux-bluetooth@vger.kernel.org
Cc: deymo@chromium.org, Mikel Astiz <mikel.astiz@bmw-carit.de>
Subject: [PATCH BlueZ v0 0/4] AVRCP connection-tracking issues
Date: Thu, 23 May 2013 11:28:25 +0200 [thread overview]
Message-ID: <1369301309-25189-1-git-send-email-mikel.astiz.oss@gmail.com> (raw)
From: Mikel Astiz <mikel.astiz@bmw-carit.de>
This patchset addresses the issues reported by Alex Deymo in the thread "audio: Connect doesn't return when audio device is off". Extracted from his message:
"There are two ways to hit this problem:
* One is to attempt a connection when the device is off,
* the other one is to attempt a connection from the host right after
you short press the button with the bluetooth logo on the speakers.
This button normally reconnects the speakers to the host, but if you
attempt a connection while the device is also doing that, you end up
in the same situation."
I have been able to reproduce the first issue, which should be fixed with patch 1/4. The second issue is addressed in patch 3/4 but I couldn't actually test it.
Patch 4/4 tries to improve the AVRCP role heuristic, which could alone fix Alex's issues, but I think the core cannot rely on this heuristic nevertheless.
Mikel Astiz (4):
avrcp: Fix missing reply to profile connect
control: Remove unused parameter
avrcp: Fix service connections not reported to core
avrcp: Don't require active sink in role heuristic
profiles/audio/avrcp.c | 17 ++++-------------
profiles/audio/control.c | 37 +++++++++++++++++++++++++++----------
profiles/audio/control.h | 7 +++----
3 files changed, 34 insertions(+), 27 deletions(-)
--
1.8.1.4
next reply other threads:[~2013-05-23 9:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 9:28 Mikel Astiz [this message]
2013-05-23 9:28 ` [PATCH BlueZ v0 1/4] avrcp: Fix missing reply to profile connect Mikel Astiz
2013-05-23 9:28 ` [PATCH BlueZ v0 2/4] control: Remove unused parameter Mikel Astiz
2013-05-23 9:28 ` [PATCH BlueZ v0 3/4] avrcp: Fix service connections not reported to core Mikel Astiz
2013-05-23 9:28 ` [PATCH BlueZ v0 4/4] avrcp: Don't require active sink in role heuristic Mikel Astiz
2013-05-23 16:21 ` [PATCH BlueZ v0 0/4] AVRCP connection-tracking issues Luiz Augusto von Dentz
2013-05-23 16:45 ` Luiz Augusto von Dentz
2013-05-23 19:45 ` Alex Deymo
2013-05-23 20:27 ` Luiz Augusto von Dentz
2013-05-23 21:05 ` Alex Deymo
2013-05-23 21:12 ` Luiz Augusto von Dentz
2013-05-23 22:46 ` Alex Deymo
2013-05-24 7:05 ` Mikel Astiz
2013-05-25 0:56 ` Luiz Augusto von Dentz
2013-05-26 9:30 ` Mikel Astiz
2013-05-27 13:07 ` Luiz Augusto von Dentz
2013-05-27 14:06 ` Mikel Astiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369301309-25189-1-git-send-email-mikel.astiz.oss@gmail.com \
--to=mikel.astiz.oss@gmail.com \
--cc=deymo@chromium.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=mikel.astiz@bmw-carit.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).