linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ 1/3] audio: Remove auto_connect flag from audio-avrcp-target
Date: Thu, 23 May 2013 11:58:29 -0700	[thread overview]
Message-ID: <1369335511-8874-1-git-send-email-luiz.dentz@gmail.com> (raw)

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

By the time the profile is registered it is not really possible to
tell which role of AVRCP should be connected, currently this cause
a problem with headsets that normally are controllers/sink but since
it normally also has target record for features related to things like
volume control the target profile is also probed and as it currently
has the auto_connect set it would lead to the wrong profile to start
connecting.
---
 profiles/audio/manager.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/profiles/audio/manager.c b/profiles/audio/manager.c
index 15226e4..1518e5d 100644
--- a/profiles/audio/manager.c
+++ b/profiles/audio/manager.c
@@ -376,7 +376,6 @@ static struct btd_profile avrcp_target_profile = {
 	.device_probe	= avrcp_probe,
 	.device_remove	= audio_remove,
 
-	.auto_connect	= true,
 	.connect	= avrcp_target_connect,
 	.disconnect	= avrcp_target_disconnect,
 
-- 
1.8.1.4


             reply	other threads:[~2013-05-23 18:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-23 18:58 Luiz Augusto von Dentz [this message]
2013-05-23 18:58 ` [PATCH BlueZ 2/3] audio: Make use of .device_probe in all AVRCP profile drivers Luiz Augusto von Dentz
2013-05-23 18:58 ` [PATCH BlueZ 3/3] audio/control: Remove control_update Luiz Augusto von Dentz
2013-05-24  0:21 ` [PATCH BlueZ 1/3] audio: Remove auto_connect flag from audio-avrcp-target Luiz Augusto von Dentz
2013-05-24  6:54   ` Mikel Astiz
2013-05-24 14:29     ` Luiz Augusto von Dentz
2013-05-24 15:43       ` Lucas De Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369335511-8874-1-git-send-email-luiz.dentz@gmail.com \
    --to=luiz.dentz@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).