From: Mikel Astiz <mikel.astiz.oss@gmail.com>
To: linux-bluetooth@vger.kernel.org
Cc: Mikel Astiz <mikel.astiz@bmw-carit.de>
Subject: [PATCH BlueZ v0 0/6] Exploit btd_service's userdata pointer
Date: Mon, 27 May 2013 14:04:03 +0200 [thread overview]
Message-ID: <1369656249-27980-1-git-send-email-mikel.astiz.oss@gmail.com> (raw)
From: Mikel Astiz <mikel.astiz@bmw-carit.de>
With the adoption of btd_service, profile implementations can benefit from the provided userdata pointer which can replace the previously necessary lists to associate services with custom private types.
The proposed change not only removes boilerplate code but also data redundancy, presumably making the codebase more robust.
This patchset addresses the first examples which looked like more obvious to refactor. Note that some of the profiles were not tested due to lack of hardware.
Patch 2/6 fixes an issue that I came across during this work.
Mikel Astiz (6):
network: Remove duplicated search
network: Fix missing NULL check for given UUID
network: Remove find_connection()
deviceinfo: Use btd_service userdata pointer
scanparam: Use btd_service userdata pointer
input: Use btd_service userdata pointer
profiles/deviceinfo/deviceinfo.c | 46 ++++++----------------------------------
profiles/input/device.c | 37 +++++++++-----------------------
profiles/network/connection.c | 38 ++++++++++++---------------------
profiles/scanparam/scan.c | 36 ++++++-------------------------
4 files changed, 35 insertions(+), 122 deletions(-)
--
1.8.1.4
next reply other threads:[~2013-05-27 12:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-27 12:04 Mikel Astiz [this message]
2013-05-27 12:04 ` [PATCH BlueZ v0 1/6] network: Remove duplicated search Mikel Astiz
2013-05-27 12:04 ` [PATCH BlueZ v0 2/6] network: Fix missing NULL check for given UUID Mikel Astiz
2013-05-27 12:04 ` [PATCH BlueZ v0 3/6] network: Remove find_connection() Mikel Astiz
2013-05-27 12:04 ` [PATCH BlueZ v0 4/6] deviceinfo: Use btd_service userdata pointer Mikel Astiz
2013-05-27 12:04 ` [PATCH BlueZ v0 5/6] scanparam: " Mikel Astiz
2013-05-27 12:04 ` [PATCH BlueZ v0 6/6] input: " Mikel Astiz
2013-06-24 8:19 ` [PATCH BlueZ v0 0/6] Exploit btd_service's " Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369656249-27980-1-git-send-email-mikel.astiz.oss@gmail.com \
--to=mikel.astiz.oss@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=mikel.astiz@bmw-carit.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).