From: Gustavo Padovan <gustavo@padovan.org>
To: linux-bluetooth@vger.kernel.org
Cc: emilio.pozuelo@collabora.co.uk,
Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Subject: [PATCH 6/6] manager: remove unused call to obex_getpeername()
Date: Tue, 28 May 2013 14:45:23 -0300 [thread overview]
Message-ID: <1369763123-17949-6-git-send-email-gustavo@padovan.org> (raw)
In-Reply-To: <1369763123-17949-1-git-send-email-gustavo@padovan.org>
From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
---
obexd/src/manager.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/obexd/src/manager.c b/obexd/src/manager.c
index a116a3e..d0991e9 100644
--- a/obexd/src/manager.c
+++ b/obexd/src/manager.c
@@ -751,10 +751,8 @@ int manager_request_authorization(struct obex_transfer *transfer, int32_t time,
DBusPendingCall *call;
const char *filename = os->name ? os->name : "";
const char *type = os->type ? os->type : "";
- char *address;
unsigned int watch;
gboolean got_reply;
- int err;
if (!agent)
return -1;
@@ -765,10 +763,6 @@ int manager_request_authorization(struct obex_transfer *transfer, int32_t time,
if (!new_folder || !new_name)
return -EINVAL;
- err = obex_getpeername(os, &address);
- if (err < 0)
- return err;
-
msg = dbus_message_new_method_call(agent->bus_name, agent->path,
AGENT_INTERFACE,
"AuthorizePush");
@@ -776,8 +770,6 @@ int manager_request_authorization(struct obex_transfer *transfer, int32_t time,
dbus_message_append_args(msg, DBUS_TYPE_OBJECT_PATH, &transfer->path,
DBUS_TYPE_INVALID);
- g_free(address);
-
if (!dbus_connection_send_with_reply(connection,
msg, &call, TIMEOUT)) {
dbus_message_unref(msg);
--
1.8.1.4
next prev parent reply other threads:[~2013-05-28 17:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 17:45 [PATCH 1/6] transport: add getsockname to transport driver Gustavo Padovan
2013-05-28 17:45 ` [PATCH 2/6] bluetooth: add getsockname() entry in the bluetooth driver Gustavo Padovan
2013-05-28 17:45 ` [PATCH 3/6] obex: add obex_getsockname() Gustavo Padovan
2013-05-28 17:45 ` [PATCH 4/6] obex: get src and dst address and store it Gustavo Padovan
2013-05-28 17:45 ` [PATCH 5/6] session: add Source and Destination properties Gustavo Padovan
2013-05-28 17:45 ` Gustavo Padovan [this message]
2013-05-29 11:41 ` [PATCH 1/6] transport: add getsockname to transport driver Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369763123-17949-6-git-send-email-gustavo@padovan.org \
--to=gustavo@padovan.org \
--cc=emilio.pozuelo@collabora.co.uk \
--cc=gustavo.padovan@collabora.co.uk \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).