linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mikel Astiz <mikel.astiz.oss@gmail.com>
To: linux-bluetooth@vger.kernel.org
Cc: Mikel Astiz <mikel.astiz@bmw-carit.de>
Subject: [RFC BlueZ v1 08/13] dbus: Add state property to org.bluez.Service1
Date: Thu,  6 Jun 2013 10:21:40 +0200	[thread overview]
Message-ID: <1370506905-19641-9-git-send-email-mikel.astiz.oss@gmail.com> (raw)
In-Reply-To: <1370506905-19641-1-git-send-email-mikel.astiz.oss@gmail.com>

From: Mikel Astiz <mikel.astiz@bmw-carit.de>

Add a property representing the current state of the service, which
currently uses a simplified subset of the internal state.
---
 src/service.c | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/src/service.c b/src/service.c
index 9487c1a..fed8460 100644
--- a/src/service.c
+++ b/src/service.c
@@ -92,10 +92,27 @@ static const char *state2str(btd_service_state_t state)
 	return NULL;
 }
 
+static const char *state2dbus(btd_service_state_t state)
+{
+	switch (state) {
+	case BTD_SERVICE_STATE_UNAVAILABLE:
+		return NULL;
+	case BTD_SERVICE_STATE_DISCONNECTED:
+	case BTD_SERVICE_STATE_CONNECTING:
+	case BTD_SERVICE_STATE_DISCONNECTING:
+		return "disconnected";
+	case BTD_SERVICE_STATE_CONNECTED:
+		return "connected";
+	}
+
+	return NULL;
+}
+
 static void change_state(struct btd_service *service, btd_service_state_t state,
 									int err)
 {
 	btd_service_state_t old = service->state;
+	DBusConnection *dbus_conn = btd_get_dbus_connection();
 	char addr[18];
 	GSList *l;
 
@@ -113,6 +130,11 @@ static void change_state(struct btd_service *service, btd_service_state_t state,
 					addr, service->profile->name,
 					state2str(old), state2str(state), err);
 
+	if (state != BTD_SERVICE_STATE_UNAVAILABLE &&
+					state2dbus(old) != state2dbus(state))
+		g_dbus_emit_property_changed(dbus_conn, service->path,
+						SERVICE_INTERFACE, "State");
+
 	for (l = state_callbacks; l != NULL; l = g_slist_next(l)) {
 		struct service_state_callback *cb = l->data;
 
@@ -370,9 +392,23 @@ static gboolean service_get_uuid(const GDBusPropertyTable *property,
 	return TRUE;
 }
 
+static gboolean service_get_state(const GDBusPropertyTable *property,
+					DBusMessageIter *iter, void *data)
+{
+	struct btd_service *service = data;
+	const char *str;
+
+	str = state2dbus(service->state);
+
+	dbus_message_iter_append_basic(iter, DBUS_TYPE_STRING, &str);
+
+	return TRUE;
+}
+
 static const GDBusPropertyTable service_properties[] = {
 	{ "Device", "o", service_get_device },
 	{ "UUID", "s", service_get_uuid },
+	{ "State", "s", service_get_state },
 	{ }
 };
 
-- 
1.8.1.4


  parent reply	other threads:[~2013-06-06  8:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-06  8:21 [RFC BlueZ v1 00/13] Add experimental org.bluez.Service1 Mikel Astiz
2013-06-06  8:21 ` [RFC BlueZ v1 01/13] test: Remove obsolete test script Mikel Astiz
2013-06-06  8:21 ` [RFC BlueZ v1 02/13] test: Add UUID alias table to bluezutils.py Mikel Astiz
2013-06-06  8:21 ` [RFC BlueZ v1 03/13] test: Support human-friendly UUIDs in test-device Mikel Astiz
2013-06-06  8:21 ` [RFC BlueZ v1 04/13] test: Show human-friendly UUIDs in list-devices Mikel Astiz
2013-06-06  8:21 ` [RFC BlueZ v1 05/13] dbus: Add new org.bluez.Service1 Mikel Astiz
2013-06-06  8:29   ` Gustavo Padovan
2013-06-06  9:26     ` Mikel Astiz
2013-06-06  8:21 ` [RFC BlueZ v1 06/13] dbus: Add Device property to org.bluez.Service1 Mikel Astiz
2013-06-06  8:21 ` [RFC BlueZ v1 07/13] dbus: Add UUID " Mikel Astiz
2013-06-06  8:21 ` Mikel Astiz [this message]
2013-06-06  8:21 ` [RFC BlueZ v1 09/13] dbus: Add Connect/Disconnect " Mikel Astiz
2013-06-06  8:21 ` [RFC BlueZ v1 10/13] doc: Add API documentation for org.bluez.Service1 Mikel Astiz
2013-06-06  8:21 ` [RFC BlueZ v1 11/13] dbus: Deprecate old profile-connecting API Mikel Astiz
2013-06-06  8:21 ` [RFC BlueZ v1 12/13] test: Add test-service script Mikel Astiz
2013-06-06  8:21 ` [RFC BlueZ v1 13/13] test: Add --uuid to test-service Mikel Astiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370506905-19641-9-git-send-email-mikel.astiz.oss@gmail.com \
    --to=mikel.astiz.oss@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=mikel.astiz@bmw-carit.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).