linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gustavo Padovan <gustavo@padovan.org>
To: linux-bluetooth@vger.kernel.org
Cc: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Subject: [RFC v1 1/9] adapter: fix setting of discoverable timeout
Date: Tue, 11 Jun 2013 01:03:23 +0100	[thread overview]
Message-ID: <1370909011-19315-1-git-send-email-gustavo@padovan.org> (raw)

From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

The mgmt_cp_set_discoverable struct was getting reset for no reason after
we set up the discoverable timeout value.
---
 src/adapter.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/adapter.c b/src/adapter.c
index 1250966..af3e3ea 100644
--- a/src/adapter.c
+++ b/src/adapter.c
@@ -1907,9 +1907,6 @@ static void property_set_mode(struct btd_adapter *adapter, uint32_t setting,
 		goto failed;
 	}
 
-	memset(&cp, 0, sizeof(cp));
-	cp.val = (enable == TRUE) ? 0x01 : 0x00;
-
 	DBG("sending %s command for index %u", mgmt_opstr(opcode),
 							adapter->dev_id);
 
-- 
1.8.1.4


             reply	other threads:[~2013-06-11  0:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-11  0:03 Gustavo Padovan [this message]
2013-06-11  0:03 ` [RFC v1 2/9] adapter: remove unused toggle_discoverable Gustavo Padovan
2013-06-11  0:03 ` [RFC v1 3/9] adapter: rename discovery_client to watch_client Gustavo Padovan
2013-06-11  0:03 ` [RFC v1 4/9] adapter: rename compare_discovery_sender Gustavo Padovan
2013-06-11  0:03 ` [RFC v1 5/9] doc: add RequestPairingSession() and ReleasePairingSession() Gustavo Padovan
2013-06-11  1:22   ` Marcel Holtmann
2013-06-11 10:00   ` Bastien Nocera
2013-06-11 10:07     ` Gustavo Padovan
2013-06-11 10:14       ` Bastien Nocera
2013-06-11  0:03 ` [RFC v1 6/9] adapter: " Gustavo Padovan
2013-06-11  0:03 ` [RFC v1 7/9] adapter: add Pairing property to report ongoing Pairing Session Gustavo Padovan
2013-06-11  0:03 ` [RFC v1 8/9] adapter: forbid properties to be set during " Gustavo Padovan
2013-06-11  0:03 ` [RFC v1 9/9] test: add pairing command to test-adapter Gustavo Padovan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370909011-19315-1-git-send-email-gustavo@padovan.org \
    --to=gustavo@padovan.org \
    --cc=gustavo.padovan@collabora.co.uk \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).