linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mikel Astiz <mikel.astiz.oss@gmail.com>
To: linux-bluetooth@vger.kernel.org
Cc: Mikel Astiz <mikel.astiz@bmw-carit.de>
Subject: [RFC BlueZ v2 11/13] dbus: Deprecate old profile-connecting API
Date: Wed, 12 Jun 2013 09:06:53 +0200	[thread overview]
Message-ID: <1371020815-22330-12-git-send-email-mikel.astiz.oss@gmail.com> (raw)
In-Reply-To: <1371020815-22330-1-git-send-email-mikel.astiz.oss@gmail.com>

From: Mikel Astiz <mikel.astiz@bmw-carit.de>

The new org.bluez.Service1 interface deprecates the old UUID-specific
connect/disconnect methods in org.bluez.Device1.
---
 doc/device-api.txt | 4 ++--
 src/device.c       | 6 ++++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/doc/device-api.txt b/doc/device-api.txt
index 6201780..5329054 100644
--- a/doc/device-api.txt
+++ b/doc/device-api.txt
@@ -40,7 +40,7 @@ Methods		void Connect()
 
 			Possible errors: org.bluez.Error.NotConnected
 
-		void ConnectProfile(string uuid)
+		void ConnectProfile(string uuid) [Deprecated]
 
 			This method connects a specific profile of this
 			device. The UUID provided is the remote service
@@ -50,7 +50,7 @@ Methods		void Connect()
 					 org.bluez.Error.AlreadyConnected
 					 org.bluez.Error.ConnectFailed
 
-		void DisconnectProfile(string uuid)
+		void DisconnectProfile(string uuid) [Deprecated]
 
 			This method disconnects a specific profile of
 			this device. The profile needs to be registered
diff --git a/src/device.c b/src/device.c
index d2be46b..7c6f2c8 100644
--- a/src/device.c
+++ b/src/device.c
@@ -1728,9 +1728,11 @@ static DBusMessage *cancel_pairing(DBusConnection *conn, DBusMessage *msg,
 static const GDBusMethodTable device_methods[] = {
 	{ GDBUS_ASYNC_METHOD("Disconnect", NULL, NULL, dev_disconnect) },
 	{ GDBUS_ASYNC_METHOD("Connect", NULL, NULL, dev_connect) },
-	{ GDBUS_ASYNC_METHOD("ConnectProfile", GDBUS_ARGS({ "UUID", "s" }),
+	{ GDBUS_DEPRECATED_ASYNC_METHOD("ConnectProfile",
+						GDBUS_ARGS({ "UUID", "s" }),
 						NULL, connect_profile) },
-	{ GDBUS_ASYNC_METHOD("DisconnectProfile", GDBUS_ARGS({ "UUID", "s" }),
+	{ GDBUS_DEPRECATED_ASYNC_METHOD("DisconnectProfile",
+						GDBUS_ARGS({ "UUID", "s" }),
 						NULL, disconnect_profile) },
 	{ GDBUS_ASYNC_METHOD("Pair", NULL, NULL, pair_device) },
 	{ GDBUS_METHOD("CancelPairing", NULL, NULL, cancel_pairing) },
-- 
1.8.1.4


  parent reply	other threads:[~2013-06-12  7:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-12  7:06 [RFC BlueZ v2 00/13] Add experimental org.bluez.Service1 Mikel Astiz
2013-06-12  7:06 ` [RFC BlueZ v2 01/13] test: Remove obsolete test script Mikel Astiz
2013-06-12  7:06 ` [RFC BlueZ v2 02/13] test: Add UUID alias table to bluezutils.py Mikel Astiz
2013-06-12  7:06 ` [RFC BlueZ v2 03/13] test: Support human-friendly UUIDs in test-device Mikel Astiz
2013-06-12  7:06 ` [RFC BlueZ v2 04/13] test: Show human-friendly UUIDs in list-devices Mikel Astiz
2013-06-12  7:06 ` [RFC BlueZ v2 05/13] dbus: Add new org.bluez.Service1 Mikel Astiz
2013-06-12  7:06 ` [RFC BlueZ v2 06/13] dbus: Add Device property to org.bluez.Service1 Mikel Astiz
2013-06-12  7:06 ` [RFC BlueZ v2 07/13] dbus: Add UUID " Mikel Astiz
2013-06-12  7:06 ` [RFC BlueZ v2 08/13] dbus: Add state " Mikel Astiz
2013-06-12  7:06 ` [RFC BlueZ v2 09/13] dbus: Add Connect/Disconnect " Mikel Astiz
2013-06-12  7:06 ` [RFC BlueZ v2 10/13] doc: Add API documentation for org.bluez.Service1 Mikel Astiz
2013-06-12  7:06 ` Mikel Astiz [this message]
2013-06-12  7:06 ` [RFC BlueZ v2 12/13] test: Add test-service script Mikel Astiz
2013-06-12  7:06 ` [RFC BlueZ v2 13/13] test: Add --uuid to test-service Mikel Astiz
2013-06-16 11:50 ` [RFC BlueZ v2 00/13] Add experimental org.bluez.Service1 Marcel Holtmann
2013-06-16 13:58   ` Mikel Astiz
2013-06-19  8:02     ` Marcel Holtmann
2013-06-19 13:00       ` Mikel Astiz
2013-06-19 21:13         ` Marcel Holtmann
2013-07-04  8:27           ` Mikel Astiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371020815-22330-12-git-send-email-mikel.astiz.oss@gmail.com \
    --to=mikel.astiz.oss@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=mikel.astiz@bmw-carit.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).