linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Frédéric Dalleau" <frederic.dalleau@linux.intel.com>
To: linux-bluetooth@vger.kernel.org
Cc: "Frédéric Dalleau" <frederic.dalleau@linux.intel.com>
Subject: [PATCH v8 0/8] sco: SCO socket option for voice_setting
Date: Fri,  5 Jul 2013 17:01:34 +0200	[thread overview]
Message-ID: <1373036503-1349-1-git-send-email-frederic.dalleau@linux.intel.com> (raw)

Hi,

v8 declares BT_VOICE_CVSD_16BIT
Merge T*, S* and D* patches in one
The last patch returns -ECONNABORTED when trying to setup a transparent data
connection if eSCO is not supported.

v7 changes defaults to BT_VOICE_CVSD
Remove mask parameter to sco_conn_defer_accept, it was always 0
check the bits for air codec instead of use constants.
Add S3, S2, S1, D1, D0 settings.
The controller default is now only used to initialize the controller or fill
in the missing information in case of using the old Add_SCO command

v6 fixes style issues

v5 changes interface to SOL_BLUETOOTH, BT_VOICE.
Rework fallback mechanism.

This is the patch version 4 of the socket option for enabling transparent SCO.
As requested by Marcel, this is now a 16-bit voice_setting.
0x0000 is the value corresponding to current behavior.
0x0003 is the value to use for enabling transparent data.
It is easy to allow all possible values from Bluetooth core spec, but I guess
results can be unexpected...
Should we filter allowed values in setsockopt ?

Let me know what you think.
Regards,
Fred


Frédéric Dalleau (8):
  Bluetooth: Use hci_connect_sco directly
  Bluetooth: Remove unused mask parameter in sco_conn_defer_accept
  Bluetooth: Add bluetooth socket voice option
  Bluetooth: Constants declaration for SCO airmode
  Bluetooth: Use voice setting in defered SCO connection request
  Bluetooth: Parameters for outgoing SCO connections
  Bluetooth: SCO connection fallback
  Bluetooth: Prevent transparent SCO on older devices

 include/net/bluetooth/bluetooth.h |    8 ++++
 include/net/bluetooth/hci_core.h  |    8 ++++
 include/net/bluetooth/sco.h       |    1 +
 net/bluetooth/hci_conn.c          |   56 +++++++++++++++++++++-----
 net/bluetooth/hci_event.c         |    3 +-
 net/bluetooth/sco.c               |   78 ++++++++++++++++++++++++++++++-------
 6 files changed, 130 insertions(+), 24 deletions(-)

-- 
1.7.9.5


             reply	other threads:[~2013-07-05 15:01 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-05 15:01 Frédéric Dalleau [this message]
2013-07-05 15:01 ` [PATCH v8 1/8] Bluetooth: Use hci_connect_sco directly Frédéric Dalleau
2013-07-05 15:01 ` [PATCH v8 2/8] Bluetooth: Remove unused mask parameter in sco_conn_defer_accept Frédéric Dalleau
2013-07-08 19:10   ` Marcel Holtmann
2013-07-09  7:00     ` Frédéric DALLEAU
2013-07-09  7:37   ` Marcel Holtmann
2013-07-05 15:01 ` [PATCH v8 3/8] Bluetooth: Add bluetooth socket voice option Frédéric Dalleau
2013-07-08 19:17   ` Marcel Holtmann
2013-07-05 15:01 ` [PATCH v8 4/8] Bluetooth: Constants declaration for SCO airmode Frédéric Dalleau
2013-07-08 19:04   ` Marcel Holtmann
2013-07-05 15:01 ` [PATCH v8 5/8] Bluetooth: Use voice setting in defered SCO connection request Frédéric Dalleau
2013-07-08 19:12   ` Marcel Holtmann
2013-07-09  9:36     ` Frédéric DALLEAU
2013-07-05 15:01 ` [PATCH v8 6/8] Bluetooth: Parameters for outgoing SCO connections Frédéric Dalleau
2013-07-08 19:20   ` Marcel Holtmann
2013-07-05 15:01 ` [PATCH v8 7/8] Bluetooth: SCO connection fallback Frédéric Dalleau
2013-07-08 19:23   ` Marcel Holtmann
2013-07-09  9:57     ` Frédéric DALLEAU
2013-07-09 14:25       ` Marcel Holtmann
2013-07-05 15:01 ` [PATCH v8 8/8] Bluetooth: Prevent transparent SCO on older devices Frédéric Dalleau
2013-07-08  2:33   ` Vinicius Costa Gomes
2013-07-08  9:31     ` Frédéric DALLEAU
2013-07-08 19:25   ` Marcel Holtmann
2013-07-12 13:48     ` Frédéric DALLEAU
2013-07-12 16:35       ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1373036503-1349-1-git-send-email-frederic.dalleau@linux.intel.com \
    --to=frederic.dalleau@linux.intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).