linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Frédéric Dalleau" <frederic.dalleau@linux.intel.com>
To: linux-bluetooth@vger.kernel.org
Cc: "Frédéric Dalleau" <frederic.dalleau@linux.intel.com>
Subject: [PATCH v8 6/8] Bluetooth: Parameters for outgoing SCO connections
Date: Fri,  5 Jul 2013 17:01:40 +0200	[thread overview]
Message-ID: <1373036503-1349-7-git-send-email-frederic.dalleau@linux.intel.com> (raw)
In-Reply-To: <1373036503-1349-1-git-send-email-frederic.dalleau@linux.intel.com>

In order to establish a transparent SCO connection, the correct settings must
be specified in the Setup Synchronous Connection request. For that,
a setting field is added to ACL connection data to set up the desired
parameters.
Remove usage of hdev->voice_setting in CVSD connection.
Make use of T2 parameters for transparent data.

Signed-off-by: Frédéric Dalleau <frederic.dalleau@linux.intel.com>
---
 include/net/bluetooth/hci_core.h |    1 +
 net/bluetooth/hci_conn.c         |   22 ++++++++++++++++++----
 2 files changed, 19 insertions(+), 4 deletions(-)

diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
index 69bdb67..61ca2ce 100644
--- a/include/net/bluetooth/hci_core.h
+++ b/include/net/bluetooth/hci_core.h
@@ -320,6 +320,7 @@ struct hci_conn {
 	__u32		passkey_notify;
 	__u8		passkey_entered;
 	__u16		disc_timeout;
+	__u16		setting;
 	unsigned long	flags;
 
 	__u8		remote_cap;
diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
index d1d9919..6282c26 100644
--- a/net/bluetooth/hci_conn.c
+++ b/net/bluetooth/hci_conn.c
@@ -185,13 +185,25 @@ void hci_setup_sync(struct hci_conn *conn, __u16 handle)
 	conn->attempt++;
 
 	cp.handle   = cpu_to_le16(handle);
-	cp.pkt_type = cpu_to_le16(conn->pkt_type);
 
 	cp.tx_bandwidth   = __constant_cpu_to_le32(0x00001f40);
 	cp.rx_bandwidth   = __constant_cpu_to_le32(0x00001f40);
-	cp.max_latency    = __constant_cpu_to_le16(0xffff);
-	cp.voice_setting  = cpu_to_le16(hdev->voice_setting);
-	cp.retrans_effort = 0xff;
+
+	switch (conn->setting & SCO_AIRMODE_MASK) {
+	case SCO_AIRMODE_TRANSP:
+		cp.pkt_type       = __constant_cpu_to_le16(EDR_ESCO_MASK &
+							   ~ESCO_2EV3);
+		cp.max_latency    = __constant_cpu_to_le16(0x000d);
+		cp.voice_setting  = __constant_cpu_to_le16(SCO_AIRMODE_TRANSP);
+		cp.retrans_effort = 0x02;
+		break;
+	case SCO_AIRMODE_CVSD:
+		cp.pkt_type       = cpu_to_le16(conn->pkt_type);
+		cp.max_latency    = __constant_cpu_to_le16(0xffff);
+		cp.voice_setting  = cpu_to_le16(conn->setting);
+		cp.retrans_effort = 0xff;
+		break;
+	}
 
 	hci_send_cmd(hdev, HCI_OP_SETUP_SYNC_CONN, sizeof(cp), &cp);
 }
@@ -584,6 +596,8 @@ struct hci_conn *hci_connect_sco(struct hci_dev *hdev, int type, bdaddr_t *dst,
 
 	hci_conn_hold(sco);
 
+	sco->setting = setting;
+
 	if (acl->state == BT_CONNECTED &&
 	    (sco->state == BT_OPEN || sco->state == BT_CLOSED)) {
 		set_bit(HCI_CONN_POWER_SAVE, &acl->flags);
-- 
1.7.9.5


  parent reply	other threads:[~2013-07-05 15:01 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-05 15:01 [PATCH v8 0/8] sco: SCO socket option for voice_setting Frédéric Dalleau
2013-07-05 15:01 ` [PATCH v8 1/8] Bluetooth: Use hci_connect_sco directly Frédéric Dalleau
2013-07-05 15:01 ` [PATCH v8 2/8] Bluetooth: Remove unused mask parameter in sco_conn_defer_accept Frédéric Dalleau
2013-07-08 19:10   ` Marcel Holtmann
2013-07-09  7:00     ` Frédéric DALLEAU
2013-07-09  7:37   ` Marcel Holtmann
2013-07-05 15:01 ` [PATCH v8 3/8] Bluetooth: Add bluetooth socket voice option Frédéric Dalleau
2013-07-08 19:17   ` Marcel Holtmann
2013-07-05 15:01 ` [PATCH v8 4/8] Bluetooth: Constants declaration for SCO airmode Frédéric Dalleau
2013-07-08 19:04   ` Marcel Holtmann
2013-07-05 15:01 ` [PATCH v8 5/8] Bluetooth: Use voice setting in defered SCO connection request Frédéric Dalleau
2013-07-08 19:12   ` Marcel Holtmann
2013-07-09  9:36     ` Frédéric DALLEAU
2013-07-05 15:01 ` Frédéric Dalleau [this message]
2013-07-08 19:20   ` [PATCH v8 6/8] Bluetooth: Parameters for outgoing SCO connections Marcel Holtmann
2013-07-05 15:01 ` [PATCH v8 7/8] Bluetooth: SCO connection fallback Frédéric Dalleau
2013-07-08 19:23   ` Marcel Holtmann
2013-07-09  9:57     ` Frédéric DALLEAU
2013-07-09 14:25       ` Marcel Holtmann
2013-07-05 15:01 ` [PATCH v8 8/8] Bluetooth: Prevent transparent SCO on older devices Frédéric Dalleau
2013-07-08  2:33   ` Vinicius Costa Gomes
2013-07-08  9:31     ` Frédéric DALLEAU
2013-07-08 19:25   ` Marcel Holtmann
2013-07-12 13:48     ` Frédéric DALLEAU
2013-07-12 16:35       ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1373036503-1349-7-git-send-email-frederic.dalleau@linux.intel.com \
    --to=frederic.dalleau@linux.intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).