From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ 00/20] Remove audio_device and introduce policy plugin
Date: Mon, 8 Jul 2013 17:10:06 +0300 [thread overview]
Message-ID: <1373292626-3776-1-git-send-email-luiz.dentz@gmail.com> (raw)
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
audio_device is no longer needed as btd_service can be used to track
connection states, in fact audio_device probably obscured direct access
to some data types like btd_device and use btd_service_set_user_data to
set profile private data instead of storing everything inside
audio_device.
There are probably more cleanups to audio after this changes, some
policies that should be moved to policy plugin and a much needed split
of audio plugin into smaller plugins, but I decided to stop right here
otherwise the patch-set will get too big to be properly reviewed.
Also since this refactore the audio policy quite extensively this may
create some IOP issues that why Im using RFC here, but I did test this
with quite a few stacks including:
- iOS 6
- Android 4.2
- WP 8
- Blackberry 10
- MW600
- Nokia Purity Pro
- BlueZ 4
They all seems to be working as before.
Luiz Augusto von Dentz (20):
audio/sink: Use service user_data for private data
audio/source: Use service user_data for private data
audio/control: Use service user_data for private data
audio/sink: Reduce dependency on struct audio_device
audio/source: Reduce dependency on struct audio_device
audio/control: Reduce dependency on struct audio_device
audio/AVCTP: Remove dependency on struct audio_device
audio/AVDTP: Remove dependency on struct audio_device
audio/AVRCP: Remove dependency on struct audio_device
audio/control: Remove dependency on struct audio_device
audio/A2DP: Remove dependency on struct audio_device
audio/sink: Remove dependency on struct audio_device
audio/source: Remove dependency on struct audio_device
audio/media: Remove dependency on struct audio_device
audio/transport: Remove dependency on struct audio_device
audio/manager: Remove dependency on struct audio_device
audio/main: Remove dependency on struct audio_device
plugins/policy: Reword audio policy code in a simple plugin
audio/source: Move stream retry logic to policy plugin
audio/sink: Move stream retry logic to policy plugin
Makefile.plugins | 4 +-
plugins/policy.c | 424 +++++++++++++++++++++++++++++++++++++++++++++
profiles/audio/a2dp.c | 110 ++++++------
profiles/audio/a2dp.h | 4 +-
profiles/audio/avctp.c | 69 +++-----
profiles/audio/avctp.h | 12 +-
profiles/audio/avdtp.c | 97 +++++------
profiles/audio/avdtp.h | 13 +-
profiles/audio/avrcp.c | 89 ++++++----
profiles/audio/avrcp.h | 8 +-
profiles/audio/control.c | 140 +++++++--------
profiles/audio/control.h | 19 +-
profiles/audio/device.c | 261 ----------------------------
profiles/audio/device.h | 43 -----
profiles/audio/main.c | 1 -
profiles/audio/manager.c | 188 +++++---------------
profiles/audio/manager.h | 10 --
profiles/audio/media.c | 39 +++--
profiles/audio/sink.c | 157 +++++++----------
profiles/audio/sink.h | 18 +-
profiles/audio/source.c | 158 +++++++----------
profiles/audio/source.h | 20 +--
profiles/audio/transport.c | 109 +++++++-----
profiles/audio/transport.h | 8 +-
24 files changed, 984 insertions(+), 1017 deletions(-)
create mode 100644 plugins/policy.c
delete mode 100644 profiles/audio/device.c
delete mode 100644 profiles/audio/device.h
--
1.8.1.4
next reply other threads:[~2013-07-08 14:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 14:10 Luiz Augusto von Dentz [this message]
2013-07-08 14:10 ` [PATCH BlueZ 01/20] audio/sink: Use service user_data for private data Luiz Augusto von Dentz
2013-07-08 14:10 ` [PATCH BlueZ 02/20] audio/source: " Luiz Augusto von Dentz
2013-07-08 14:10 ` [PATCH BlueZ 03/20] audio/control: " Luiz Augusto von Dentz
2013-07-08 14:10 ` [PATCH BlueZ 04/20] audio/sink: Reduce dependency on struct audio_device Luiz Augusto von Dentz
2013-07-08 14:10 ` [PATCH BlueZ 05/20] audio/source: " Luiz Augusto von Dentz
2013-07-08 14:10 ` [PATCH BlueZ 06/20] audio/control: " Luiz Augusto von Dentz
2013-07-08 14:10 ` [PATCH BlueZ 07/20] audio/AVCTP: Remove " Luiz Augusto von Dentz
2013-07-08 14:10 ` [PATCH BlueZ 08/20] audio/AVDTP: " Luiz Augusto von Dentz
2013-07-08 14:10 ` [PATCH BlueZ 09/20] audio/AVRCP: " Luiz Augusto von Dentz
2013-07-08 14:10 ` [PATCH BlueZ 10/20] audio/control: " Luiz Augusto von Dentz
2013-07-08 14:10 ` [PATCH BlueZ 11/20] audio/A2DP: " Luiz Augusto von Dentz
2013-07-08 14:10 ` [PATCH BlueZ 12/20] audio/sink: " Luiz Augusto von Dentz
2013-07-08 14:10 ` [PATCH BlueZ 13/20] audio/source: " Luiz Augusto von Dentz
2013-07-08 14:10 ` [PATCH BlueZ 14/20] audio/media: " Luiz Augusto von Dentz
2013-07-08 14:10 ` [PATCH BlueZ 15/20] audio/transport: " Luiz Augusto von Dentz
2013-07-08 14:10 ` [PATCH BlueZ 16/20] audio/manager: " Luiz Augusto von Dentz
2013-07-08 14:10 ` [PATCH BlueZ 17/20] audio/main: " Luiz Augusto von Dentz
2013-07-08 14:10 ` [PATCH BlueZ 18/20] plugins/policy: Reword audio policy code in a simple plugin Luiz Augusto von Dentz
2013-07-08 14:10 ` [PATCH BlueZ 19/20] audio/source: Move stream retry logic to policy plugin Luiz Augusto von Dentz
2013-07-08 14:10 ` [PATCH BlueZ 20/20] audio/sink: " Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373292626-3776-1-git-send-email-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).