Linux bluetooth development
 help / color / mirror / Atom feed
From: Anderson Lizardo <anderson.lizardo@openbossa.org>
To: linux-bluetooth@vger.kernel.org
Cc: Anderson Lizardo <anderson.lizardo@openbossa.org>
Subject: [PATCH BlueZ 1/5] scanparam: Fix handle range check on descriptor discovery
Date: Mon, 29 Jul 2013 09:59:28 -0400	[thread overview]
Message-ID: <1375106372-2255-1-git-send-email-anderson.lizardo@openbossa.org> (raw)

When discovering descriptors, if there is only a single descriptor, the
start handle will be equal to the end handle. It is valid to issue the
Find Information Request on this case.

Before this fix, notification for Scan Refresh characteristic was never
enabled.
---
 profiles/scanparam/scan.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/profiles/scanparam/scan.c b/profiles/scanparam/scan.c
index f5db5ed..0ad2e17 100644
--- a/profiles/scanparam/scan.c
+++ b/profiles/scanparam/scan.c
@@ -158,7 +158,7 @@ static void refresh_discovered_cb(GSList *chars, guint8 status,
 	start = chr->value_handle + 1;
 	end = scan->range.end;
 
-	if (start >= end)
+	if (start > end)
 		return;
 
 	scan->refresh_handle = chr->value_handle;
-- 
1.7.9.5


             reply	other threads:[~2013-07-29 13:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-29 13:59 Anderson Lizardo [this message]
2013-07-29 13:59 ` [PATCH BlueZ 2/5] scanparam: Remove unnecessary assignment Anderson Lizardo
2013-07-29 13:59 ` [PATCH BlueZ 3/5] scanparam: Fix missing check for valid GAttrib when removing device Anderson Lizardo
2013-07-29 13:59 ` [PATCH BlueZ 4/5] scanparam: Apply convention for "GSource id" like variable Anderson Lizardo
2013-07-29 13:59 ` [PATCH BlueZ 5/5] scanparam: Remove unneeded header include Anderson Lizardo
2013-07-30  9:52 ` [PATCH BlueZ 1/5] scanparam: Fix handle range check on descriptor discovery Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1375106372-2255-1-git-send-email-anderson.lizardo@openbossa.org \
    --to=anderson.lizardo@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox