linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ 2/8] gdbus: Add g_dbus_send_message_with_reply
Date: Mon, 19 Aug 2013 17:32:53 +0300	[thread overview]
Message-ID: <1376922779-11802-4-git-send-email-luiz.dentz@gmail.com> (raw)
In-Reply-To: <1376922779-11802-1-git-send-email-luiz.dentz@gmail.com>

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

g_dbus_send_message_with_reply flushes pending signals before calling
dbus_connection_send_with_reply so it does not alter the message order
---
 gdbus/gdbus.h  |  3 +++
 gdbus/object.c | 11 +++++++++++
 2 files changed, 14 insertions(+)

diff --git a/gdbus/gdbus.h b/gdbus/gdbus.h
index 8b13393..9542109 100644
--- a/gdbus/gdbus.h
+++ b/gdbus/gdbus.h
@@ -250,6 +250,9 @@ DBusMessage *g_dbus_create_reply_valist(DBusMessage *message,
 						int type, va_list args);
 
 gboolean g_dbus_send_message(DBusConnection *connection, DBusMessage *message);
+gboolean g_dbus_send_message_with_reply(DBusConnection *connection,
+					DBusMessage *message,
+					DBusPendingCall **call, int timeout);
 gboolean g_dbus_send_error(DBusConnection *connection, DBusMessage *message,
 				const char *name, const char *format, ...)
 					 __attribute__((format(printf, 4, 5)));
diff --git a/gdbus/object.c b/gdbus/object.c
index b2ca1c2..5d43036 100644
--- a/gdbus/object.c
+++ b/gdbus/object.c
@@ -1550,6 +1550,17 @@ out:
 	return result;
 }
 
+gboolean g_dbus_send_message_with_reply(DBusConnection *connection,
+					DBusMessage *message,
+					DBusPendingCall **call, int timeout)
+{
+	/* Flush pending signal to guarantee message order */
+	g_dbus_flush(connection);
+
+	return dbus_connection_send_with_reply(connection, message, call,
+								timeout);
+}
+
 gboolean g_dbus_send_error_valist(DBusConnection *connection,
 					DBusMessage *message, const char *name,
 					const char *format, va_list args)
-- 
1.8.3.1


  parent reply	other threads:[~2013-08-19 14:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-19 14:32 [PATCH BlueZ 0/8] Fix message order Luiz Augusto von Dentz
2013-08-19 14:32 ` [PATCH BlueZ] build: Fix not checking readline.h for bluetooth-player Luiz Augusto von Dentz
2013-08-20 12:28   ` Luiz Augusto von Dentz
2013-08-19 14:32 ` [PATCH BlueZ 1/8] gdbus: Fix not maintaining message order for signals Luiz Augusto von Dentz
2013-08-19 23:59   ` Lucas De Marchi
2013-08-19 14:32 ` Luiz Augusto von Dentz [this message]
2013-08-19 14:32 ` [PATCH BlueZ 3/8] gdbus: Avoid calling dbus_connection_send* Luiz Augusto von Dentz
2013-08-19 14:32 ` [PATCH BlueZ 4/8] gdbus: Fix emitting PropertiesChanged twice Luiz Augusto von Dentz
2013-08-19 14:32 ` [PATCH BlueZ 5/8] core: Make use of g_dbus_send_message_with_reply Luiz Augusto von Dentz
2013-08-19 14:32 ` [PATCH BlueZ 6/8] neard: " Luiz Augusto von Dentz
2013-08-19 14:32 ` [PATCH BlueZ 7/8] audio/media: " Luiz Augusto von Dentz
2013-08-19 14:32 ` [PATCH BlueZ 8/8] obexd: Make use of g_dbus_send_message* Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1376922779-11802-4-git-send-email-luiz.dentz@gmail.com \
    --to=luiz.dentz@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).