* [PATCH] Bluetooth: Use GFP_KERNEL when cloning SKB in a workqueue
@ 2013-09-04 1:11 Marcel Holtmann
2013-09-06 10:41 ` Johan Hedberg
2013-09-10 15:48 ` Gustavo Padovan
0 siblings, 2 replies; 3+ messages in thread
From: Marcel Holtmann @ 2013-09-04 1:11 UTC (permalink / raw)
To: linux-bluetooth
There is no need to use GFP_ATOMIC with skb_clone() when the code is
executed in a workqueue.
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
---
net/bluetooth/hci_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index 1b86c78..4dbb6cb 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -3537,7 +3537,7 @@ static void hci_cmd_work(struct work_struct *work)
kfree_skb(hdev->sent_cmd);
- hdev->sent_cmd = skb_clone(skb, GFP_ATOMIC);
+ hdev->sent_cmd = skb_clone(skb, GFP_KERNEL);
if (hdev->sent_cmd) {
atomic_dec(&hdev->cmd_cnt);
hci_send_frame(skb);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Bluetooth: Use GFP_KERNEL when cloning SKB in a workqueue
2013-09-04 1:11 [PATCH] Bluetooth: Use GFP_KERNEL when cloning SKB in a workqueue Marcel Holtmann
@ 2013-09-06 10:41 ` Johan Hedberg
2013-09-10 15:48 ` Gustavo Padovan
1 sibling, 0 replies; 3+ messages in thread
From: Johan Hedberg @ 2013-09-06 10:41 UTC (permalink / raw)
To: Marcel Holtmann; +Cc: linux-bluetooth
Hi Marcel,
On Tue, Sep 03, 2013, Marcel Holtmann wrote:
> There is no need to use GFP_ATOMIC with skb_clone() when the code is
> executed in a workqueue.
>
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> ---
> net/bluetooth/hci_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Johan Hedberg <johan.hedberg@intel.com>
Johan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Bluetooth: Use GFP_KERNEL when cloning SKB in a workqueue
2013-09-04 1:11 [PATCH] Bluetooth: Use GFP_KERNEL when cloning SKB in a workqueue Marcel Holtmann
2013-09-06 10:41 ` Johan Hedberg
@ 2013-09-10 15:48 ` Gustavo Padovan
1 sibling, 0 replies; 3+ messages in thread
From: Gustavo Padovan @ 2013-09-10 15:48 UTC (permalink / raw)
To: Marcel Holtmann; +Cc: linux-bluetooth
Hi Marcel,
2013-09-03 Marcel Holtmann <marcel@holtmann.org>:
> There is no need to use GFP_ATOMIC with skb_clone() when the code is
> executed in a workqueue.
>
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> ---
> net/bluetooth/hci_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch has been applied to bluetooth-next. Thanks.
Gustavo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-10 15:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-04 1:11 [PATCH] Bluetooth: Use GFP_KERNEL when cloning SKB in a workqueue Marcel Holtmann
2013-09-06 10:41 ` Johan Hedberg
2013-09-10 15:48 ` Gustavo Padovan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).