From: Denis Kenzior <denkenz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Cc: Denis Kenzior <denkenz@gmail.com>
Subject: [PATCH 2/3] doc: Remove Profile1.Cancel() method
Date: Tue, 10 Sep 2013 11:42:22 -0500 [thread overview]
Message-ID: <1378831343-3534-2-git-send-email-denkenz@gmail.com> (raw)
In-Reply-To: <1378831343-3534-1-git-send-email-denkenz@gmail.com>
There does not seem to be any actual need for this method.
The current implementation calls Cancel when a pending
NewConnection() or RequestDisconnection() method call fails.
Additionally it calls Cancel() when the remote client has disconnected.
In either case BlueZ calls shutdown on the file descriptor associated
with the agent and issues a Cancel() method call.
The closing of the file descriptor will trigger a HUP on the agent side,
which will trigger normal cleanup procedures. The received Cancel()
method call is redundant in both cases.
---
doc/profile-api.txt | 8 --------
1 file changed, 8 deletions(-)
diff --git a/doc/profile-api.txt b/doc/profile-api.txt
index 96cfce9..ec18034 100644
--- a/doc/profile-api.txt
+++ b/doc/profile-api.txt
@@ -145,11 +145,3 @@ Methods void Release() [noreply]
Possible errors: org.bluez.Error.Rejected
org.bluez.Error.Canceled
-
- void Cancel()
-
- This method gets called to indicate that the profile
- request failed before a reply was returned.
-
- All request are queued and there will be only one
- pending pequest at a time per profile.
--
1.8.1.5
next prev parent reply other threads:[~2013-09-10 16:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 16:42 [PATCH 1/3] doc: Label Profile1.Release() method as no reply Denis Kenzior
2013-09-10 16:42 ` Denis Kenzior [this message]
2013-09-10 16:42 ` [PATCH 3/3] profile: Remove support for Cancel method Denis Kenzior
2013-09-11 18:49 ` [PATCH 1/3] doc: Label Profile1.Release() method as no reply Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378831343-3534-2-git-send-email-denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).