linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: johan.hedberg@gmail.com
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH v5 2/8] Bluetooth: Fix double error response for l2cap_create_chan_req
Date: Mon, 16 Sep 2013 13:05:13 +0300	[thread overview]
Message-ID: <1379325919-19003-3-git-send-email-johan.hedberg@gmail.com> (raw)
In-Reply-To: <1379325919-19003-1-git-send-email-johan.hedberg@gmail.com>

From: Johan Hedberg <johan.hedberg@intel.com>

When an L2CAP request handler returns non-zero the calling code will
send a command reject response. The l2cap_create_chan_req function will
in some cases send its own response but then still return a -EFAULT
error which would cause two responses to be sent. This patch fixes this
by making the function return 0 after sending its own response.

Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
---
 net/bluetooth/l2cap_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
index b3bb7bc..0b8a270 100644
--- a/net/bluetooth/l2cap_core.c
+++ b/net/bluetooth/l2cap_core.c
@@ -4462,7 +4462,7 @@ error:
 	l2cap_send_cmd(conn, cmd->ident, L2CAP_CREATE_CHAN_RSP,
 		       sizeof(rsp), &rsp);
 
-	return -EFAULT;
+	return 0;
 }
 
 static void l2cap_send_move_chan_req(struct l2cap_chan *chan, u8 dest_amp_id)
-- 
1.8.4.rc3


  parent reply	other threads:[~2013-09-16 10:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-16 10:05 [PATCH v5 0/8] Bluetooth: Various L2CAP fixes johan.hedberg
2013-09-16 10:05 ` [PATCH v5 1/8] Bluetooth: Remove unused event mask struct johan.hedberg
2013-09-16 10:05 ` johan.hedberg [this message]
2013-09-16 10:05 ` [PATCH v5 3/8] Bluetooth: Fix L2CAP error return used for failed channel lookups johan.hedberg
2013-09-16 14:12   ` Marcel Holtmann
2013-09-16 10:05 ` [PATCH v5 4/8] Bluetooth: Fix L2CAP Disconnect response for unknown CID johan.hedberg
2013-09-16 14:10   ` Marcel Holtmann
2013-09-16 10:05 ` [PATCH v5 5/8] Bluetooth: Fix L2CAP command reject reason johan.hedberg
2013-09-16 14:11   ` Marcel Holtmann
2013-09-16 10:05 ` [PATCH v5 6/8] Bluetooth: Fix sending responses to identified L2CAP response packets johan.hedberg
2013-09-16 10:05 ` [PATCH v5 7/8] Bluetooth: Fix responding to invalid L2CAP signaling commands johan.hedberg
2013-09-16 10:05 ` [PATCH v5 8/8] Bluetooth: Fix waiting for clearing of BT_SK_SUSPEND flag johan.hedberg
2013-09-16 14:13   ` Marcel Holtmann
2013-09-18 22:04   ` Gustavo Padovan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1379325919-19003-3-git-send-email-johan.hedberg@gmail.com \
    --to=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).