From: johan.hedberg@gmail.com
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH 2/8] Bluetooth: Clean up socket locking in l2cap_sock_recvmsg
Date: Tue, 24 Sep 2013 17:02:37 +0300 [thread overview]
Message-ID: <1380031363-1266-3-git-send-email-johan.hedberg@gmail.com> (raw)
In-Reply-To: <1380031363-1266-1-git-send-email-johan.hedberg@gmail.com>
From: Johan Hedberg <johan.hedberg@intel.com>
This patch cleans up the locking login in l2cap_sock_recvmsg by pairing
up each lock_sock call with a release_sock call. The function already
has a "done" label that handles releasing the socket and returning from
the function so the fix is rather simple.
Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
---
net/bluetooth/l2cap_sock.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/net/bluetooth/l2cap_sock.c b/net/bluetooth/l2cap_sock.c
index ad95b42..5853c1e 100644
--- a/net/bluetooth/l2cap_sock.c
+++ b/net/bluetooth/l2cap_sock.c
@@ -795,7 +795,7 @@ static int l2cap_sock_recvmsg(struct kiocb *iocb, struct socket *sock,
{
struct sock *sk = sock->sk;
struct l2cap_pinfo *pi = l2cap_pi(sk);
- int err;
+ int err = 0;
lock_sock(sk);
@@ -805,8 +805,7 @@ static int l2cap_sock_recvmsg(struct kiocb *iocb, struct socket *sock,
pi->chan->state = BT_CONFIG;
__l2cap_connect_rsp_defer(pi->chan);
- release_sock(sk);
- return 0;
+ goto done;
}
release_sock(sk);
--
1.8.4.rc3
next prev parent reply other threads:[~2013-09-24 14:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 14:02 [PATCH 0/8] Bluetooth: Cleanups and LE advertising support johan.hedberg
2013-09-24 14:02 ` [PATCH 1/8] Bluetooth: Add clarifying comment to bt_sock_wait_state() johan.hedberg
2013-09-24 18:11 ` Marcel Holtmann
2013-09-24 14:02 ` johan.hedberg [this message]
2013-09-24 18:16 ` [PATCH 2/8] Bluetooth: Clean up socket locking in l2cap_sock_recvmsg Marcel Holtmann
2013-09-24 14:02 ` [PATCH 3/8] Bluetooth: Test for HCI_SETUP and HCI_USER_CHANNEL in mgmt_valid_hdev() johan.hedberg
2013-09-24 18:19 ` Marcel Holtmann
2013-09-25 10:03 ` Johan Hedberg
2013-09-27 2:12 ` Marcel Holtmann
2013-09-27 11:45 ` Johan Hedberg
2013-09-28 8:06 ` Marcel Holtmann
2013-09-28 15:34 ` Johan Hedberg
2013-09-24 14:02 ` [PATCH 4/8] Bluetooth: Fix busy return for mgmt_set_powered in some cases johan.hedberg
2013-09-24 18:17 ` Marcel Holtmann
2013-09-24 14:02 ` [PATCH 5/8] Bluetooth: Move mgmt response convenience functions to a better location johan.hedberg
2013-09-24 18:11 ` Marcel Holtmann
2013-09-24 14:02 ` [PATCH 6/8] Bluetooth: Use async request for LE enable/disable johan.hedberg
2013-09-24 18:20 ` Marcel Holtmann
2013-09-24 14:02 ` [PATCH 7/8] Bluetooth: Add new mgmt setting for LE advertising johan.hedberg
2013-09-24 15:45 ` Anderson Lizardo
2013-09-24 17:21 ` Johan Hedberg
2013-09-25 10:28 ` Johan Hedberg
2013-09-24 18:29 ` Marcel Holtmann
2013-09-24 14:02 ` [PATCH 8/8] Bluetooth: Add new mgmt_set_advertising command johan.hedberg
2013-09-24 15:42 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380031363-1266-3-git-send-email-johan.hedberg@gmail.com \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox