From: Andre Guedes <andre.guedes@openbossa.org>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH v2 2/4] Bluetooth: Initialize hci_conn fields in hci_connect_le
Date: Thu, 3 Oct 2013 18:25:45 -0300 [thread overview]
Message-ID: <1380835547-3640-3-git-send-email-andre.guedes@openbossa.org> (raw)
In-Reply-To: <1380835547-3640-1-git-send-email-andre.guedes@openbossa.org>
This patch moves some hci_conn fields initialization from hci_le_
create_connection() to hci_connect_le(). It makes more sense to
initialize these fields within the function that creates the hci_
conn object.
Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
---
net/bluetooth/hci_conn.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
index 5aba520..08e601c 100644
--- a/net/bluetooth/hci_conn.c
+++ b/net/bluetooth/hci_conn.c
@@ -54,11 +54,6 @@ static void hci_le_create_connection(struct hci_conn *conn)
struct hci_dev *hdev = conn->hdev;
struct hci_cp_le_create_conn cp;
- conn->state = BT_CONNECT;
- conn->out = true;
- conn->link_mode |= HCI_LM_MASTER;
- conn->sec_level = BT_SECURITY_LOW;
-
memset(&cp, 0, sizeof(cp));
cp.scan_interval = __constant_cpu_to_le16(0x0060);
cp.scan_window = __constant_cpu_to_le16(0x0030);
@@ -565,6 +560,11 @@ static struct hci_conn *hci_connect_le(struct hci_dev *hdev, bdaddr_t *dst,
return ERR_PTR(-ENOMEM);
conn->dst_type = bdaddr_to_le(dst_type);
+ conn->state = BT_CONNECT;
+ conn->out = true;
+ conn->link_mode |= HCI_LM_MASTER;
+ conn->sec_level = BT_SECURITY_LOW;
+
hci_le_create_connection(conn);
}
--
1.8.4
next prev parent reply other threads:[~2013-10-03 21:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 21:25 [PATCH v2 0/4] LE connection refactoring and fixes Andre Guedes
2013-10-03 21:25 ` [PATCH v2 1/4] Bluetooth: Rename hci_conn variable in hci_connect_le() Andre Guedes
2013-10-04 6:08 ` Marcel Holtmann
2013-10-03 21:25 ` Andre Guedes [this message]
2013-10-04 6:09 ` [PATCH v2 2/4] Bluetooth: Initialize hci_conn fields in hci_connect_le Marcel Holtmann
2013-10-03 21:25 ` [PATCH v2 3/4] Bluetooth: Use HCI request for LE connection Andre Guedes
2013-10-04 6:25 ` Marcel Holtmann
2013-10-04 20:57 ` Andre Guedes
2013-10-03 21:25 ` [PATCH v2 4/4] Bluetooth: Refactor hci_connect_le Andre Guedes
2013-10-04 6:27 ` Marcel Holtmann
2013-10-04 20:58 ` Andre Guedes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380835547-3640-3-git-send-email-andre.guedes@openbossa.org \
--to=andre.guedes@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox