From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ 5/7] profiles/AVRCP: Add AV Remote Controller service class id to CT
Date: Wed, 9 Oct 2013 14:11:43 +0300 [thread overview]
Message-ID: <1381317105-10729-5-git-send-email-luiz.dentz@gmail.com> (raw)
In-Reply-To: <1381317105-10729-1-git-send-email-luiz.dentz@gmail.com>
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Both AV Remote and AV Remote Controller service classes are mandatory
by AVRCP CT role from 1.3 onwards. Also the assigned numbers page mention
that AV Remote must appear before AV Remote Controller:
"The AVRCP specification v1.3 and later require that 0x110E also be
included in the ServiceClassIDList before 0x110F for backwards
compatibility."
---
profiles/audio/avrcp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/profiles/audio/avrcp.c b/profiles/audio/avrcp.c
index b1b2ae6..296067c 100644
--- a/profiles/audio/avrcp.c
+++ b/profiles/audio/avrcp.c
@@ -263,7 +263,7 @@ static void avrcp_register_notification(struct avrcp *session, uint8_t event);
static sdp_record_t *avrcp_ct_record(void)
{
sdp_list_t *svclass_id, *pfseq, *apseq, *apseq1, *root;
- uuid_t root_uuid, l2cap, avctp, avrct;
+ uuid_t root_uuid, l2cap, avctp, avrct, avrctr;
sdp_profile_desc_t profile[1];
sdp_list_t *aproto, *aproto1, *proto[2], *proto1[2];
sdp_record_t *record;
@@ -287,6 +287,8 @@ static sdp_record_t *avrcp_ct_record(void)
/* Service Class ID List */
sdp_uuid16_create(&avrct, AV_REMOTE_SVCLASS_ID);
svclass_id = sdp_list_append(0, &avrct);
+ sdp_uuid16_create(&avrctr, AV_REMOTE_CONTROLLER_SVCLASS_ID);
+ svclass_id = sdp_list_append(svclass_id, &avrctr);
sdp_set_service_classes(record, svclass_id);
/* Protocol Descriptor List */
--
1.8.3.1
next prev parent reply other threads:[~2013-10-09 11:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 11:11 [PATCH BlueZ 1/7] core/profile: Fix MNS record version Luiz Augusto von Dentz
2013-10-09 11:11 ` [PATCH BlueZ 2/7] obexd/MAP: Fix sending \0 after filler byte Luiz Augusto von Dentz
2013-10-09 11:11 ` [PATCH BlueZ 3/7] obexd/MAP: Fix parsing message handles as decimal numbers Luiz Augusto von Dentz
2013-10-09 11:11 ` [PATCH BlueZ 4/7] lib/sdp: Replace VIDEO_CONF_SVCLASS_ID with AV_REMOTE_CONTROLLER_SVCLASS_ID Luiz Augusto von Dentz
2013-10-09 11:11 ` Luiz Augusto von Dentz [this message]
2013-10-09 11:11 ` [PATCH BlueZ 6/7] tools/sdptool: Fix parsing for service class 0x110f Luiz Augusto von Dentz
2013-10-09 11:11 ` [PATCH BlueZ 7/7] tools/hcidump: " Luiz Augusto von Dentz
2013-10-09 15:42 ` [PATCH BlueZ 1/7] core/profile: Fix MNS record version Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381317105-10729-5-git-send-email-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox