From: johan.hedberg@gmail.com
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH 5/5] Bluetooth: Fix updating advertising data needlessly
Date: Mon, 14 Oct 2013 16:20:07 +0300 [thread overview]
Message-ID: <1381756807-14900-6-git-send-email-johan.hedberg@gmail.com> (raw)
In-Reply-To: <1381756807-14900-1-git-send-email-johan.hedberg@gmail.com>
From: Johan Hedberg <johan.hedberg@intel.com>
We need to ensure that the advertising data is up-to-date whenever
advertising is enabled, but when disabling advertising we do not need to
worry about it (since it will eventually get fixed as soon as
advertising is enabled again). This patch fixes this in the command
complete callback for set_adv_enable.
Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
---
net/bluetooth/hci_event.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index aa6fed3..da2bc3d 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -924,7 +924,7 @@ static void hci_cc_le_set_adv_enable(struct hci_dev *hdev, struct sk_buff *skb)
clear_bit(HCI_ADVERTISING, &hdev->dev_flags);
}
- if (!test_bit(HCI_INIT, &hdev->flags)) {
+ if (*sent && !test_bit(HCI_INIT, &hdev->flags)) {
struct hci_request req;
hci_req_init(&req, hdev);
--
1.8.3.1
next prev parent reply other threads:[~2013-10-14 13:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 13:20 [PATCH 0/5] Bluetooth: Clean up Set Connectable related code johan.hedberg
2013-10-14 13:20 ` [PATCH 1/5] Bluetooth: Reorganize set_connectable HCI command sending johan.hedberg
2013-10-14 13:20 ` [PATCH 2/5] Bluetooth: Move move logic into set_connectable complete callback johan.hedberg
2013-10-14 13:20 ` [PATCH 3/5] Bluetooth: Add missing error handling for Set Connectable johan.hedberg
2013-10-14 13:20 ` [PATCH 4/5] Bluetooth: Move static advertising functions to avoid forward declarations johan.hedberg
2013-10-14 13:20 ` johan.hedberg [this message]
2013-10-14 13:46 ` [PATCH 0/5] Bluetooth: Clean up Set Connectable related code Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381756807-14900-6-git-send-email-johan.hedberg@gmail.com \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox