From: Andre Guedes <andre.guedes@openbossa.org>
To: linux-bluetooth@vger.kernel.org
Subject: [RFC 13/15] Bluetooth: Fix background trigger/untrigger functions
Date: Wed, 16 Oct 2013 20:18:03 -0300 [thread overview]
Message-ID: <1381965485-9159-14-git-send-email-andre.guedes@openbossa.org> (raw)
In-Reply-To: <1381965485-9159-1-git-send-email-andre.guedes@openbossa.org>
This patch fixes to hci_trigger_background_scan() and hci_untrigger_
background_scan() so they can be called concurrently with the device
discovery procedure.
In hci_trigger_background_scan(), if it is the first trigger, we are
supposed to start the background scanning. However, if device discovery
is running, we should not send any HCI command. The background scanning
will be started once the discovery procedure is finished.
In hci_untrigger_background_scan(), if it is the last trigger, we are
supposed to stop the background scanning. However, if discovery is
running, it means the background is stopped so we don't need to send
any HCI command.
Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
---
net/bluetooth/hci_core.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index ed5ce58..ace77e3 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -3929,6 +3929,12 @@ int hci_trigger_background_scan(struct hci_dev *hdev)
if (atomic_read(&hdev->background_scan_cnt) > 0)
goto done;
+ /* If discovery is running, we should not start the background
+ * scanning. It will be started once the discovery procedure finishes.
+ */
+ if (hdev->discovery.state == DISCOVERY_FINDING)
+ goto done;
+
err = start_background_scan(hdev);
if (err)
return err;
@@ -3958,6 +3964,10 @@ int hci_untrigger_background_scan(struct hci_dev *hdev)
if (!test_bit(HCI_LE_SCAN, &hdev->dev_flags))
goto done;
+ /* If device discovery is running, don't stop scanning. */
+ if (hdev->discovery.state == DISCOVERY_FINDING)
+ goto done;
+
hci_req_init(&req, hdev);
memset(&cp, 0, sizeof(cp));
--
1.8.4
next prev parent reply other threads:[~2013-10-16 23:18 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 23:17 [RFC 00/15] LE auto connection and connection parameters Andre Guedes
2013-10-16 23:17 ` [RFC 01/15] Bluetooth: Introduce connection parameters list Andre Guedes
2013-10-16 23:17 ` [RFC 02/15] Bluetooth: Mgmt command for adding connection parameters Andre Guedes
2013-10-17 9:22 ` Marcel Holtmann
2013-10-18 14:07 ` Andre Guedes
2013-10-16 23:17 ` [RFC 03/15] Bluetooth: Mgmt command for removing " Andre Guedes
2013-10-16 23:17 ` [RFC 04/15] Bluetooth: Make find_conn_param() helper non-local Andre Guedes
2013-10-16 23:17 ` [RFC 05/15] Bluetooth: Use connection parameters if any Andre Guedes
2013-10-17 9:27 ` Marcel Holtmann
2013-10-18 14:07 ` Andre Guedes
2013-10-16 23:17 ` [RFC 06/15] Bluetooth: Background scanning Andre Guedes
2013-10-17 9:31 ` Marcel Holtmann
2013-10-18 14:26 ` Andre Guedes
2013-10-16 23:17 ` [RFC 07/15] Bluetooth: Refactor hci_disconn_complete_evt Andre Guedes
2013-10-17 9:33 ` Marcel Holtmann
2013-10-18 14:08 ` Andre Guedes
2013-10-18 14:17 ` Andre Guedes
2013-10-16 23:17 ` [RFC 08/15] Bluetooth: Add support for BT_AUTO_CONN_ALWAYS Andre Guedes
2013-10-17 9:40 ` Marcel Holtmann
2013-10-16 23:17 ` [RFC 09/15] Bluetooth: Add support for BT_AUTO_CONN_LINK_LOSS option Andre Guedes
2013-10-16 23:18 ` [RFC 10/15] Bluetooth: Create start_background_scan helper Andre Guedes
2013-10-16 23:18 ` [RFC 11/15] Bluetooth: Temporarily stop background scanning on connection Andre Guedes
2013-10-17 9:43 ` Marcel Holtmann
2013-10-18 14:08 ` Andre Guedes
2013-10-16 23:18 ` [RFC 12/15] Bluetooth: Temporarily stop background scanning on discovery Andre Guedes
2013-10-16 23:18 ` Andre Guedes [this message]
2013-10-16 23:18 ` [RFC 14/15] Bluetooth: Fix hci_create_le_conn() Andre Guedes
2013-10-16 23:18 ` [RFC 15/15] Bluetooth: Auto connection and power off/on Andre Guedes
2013-10-17 10:55 ` Marcel Holtmann
2013-10-18 14:08 ` Andre Guedes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381965485-9159-14-git-send-email-andre.guedes@openbossa.org \
--to=andre.guedes@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox