From: Szymon Janc <szymon.janc@tieto.com>
To: <linux-bluetooth@vger.kernel.org>
Cc: Szymon Janc <szymon.janc@tieto.com>
Subject: [PATCH v2 01/15] android: Remove not needed local variable in connect_hal
Date: Fri, 25 Oct 2013 12:49:57 +0200 [thread overview]
Message-ID: <1382698211-9123-1-git-send-email-szymon.janc@tieto.com> (raw)
err variable was set but never read.
---
android/main.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/android/main.c b/android/main.c
index 50b5901..18dc9f7 100644
--- a/android/main.c
+++ b/android/main.c
@@ -239,12 +239,12 @@ static GIOChannel *connect_hal(GIOFunc connect_cb)
struct sockaddr_un addr;
GIOCondition cond;
GIOChannel *io;
- int err, sk;
+ int sk;
sk = socket(PF_LOCAL, SOCK_SEQPACKET, 0);
if (sk < 0) {
- err = errno;
- error("Failed to create socket: %d (%s)", err, strerror(err));
+ error("Failed to create socket: %d (%s)", errno,
+ strerror(errno));
return NULL;
}
@@ -258,9 +258,7 @@ static GIOChannel *connect_hal(GIOFunc connect_cb)
memcpy(addr.sun_path, BLUEZ_HAL_SK_PATH, sizeof(BLUEZ_HAL_SK_PATH));
- err = connect(sk, (struct sockaddr *) &addr, sizeof(addr));
- if (err < 0) {
- err = -errno;
+ if (connect(sk, (struct sockaddr *) &addr, sizeof(addr)) < 0) {
error("Failed to connect HAL socket: %d (%s)", errno,
strerror(errno));
g_io_channel_unref(io);
--
1.8.4.1
next reply other threads:[~2013-10-25 10:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-25 10:49 Szymon Janc [this message]
2013-10-25 10:49 ` [PATCH v2 02/15] android: Add properties defines to hal-msg.h Szymon Janc
2013-10-25 10:49 ` [PATCH v2 03/15] android/hal: Add support for sending adapter set property command Szymon Janc
2013-10-25 10:50 ` [PATCH v2 04/15] android/hal: Add support for sending adapter get " Szymon Janc
2013-10-25 10:50 ` [PATCH v2 05/15] android/hal: Add support for sending adapter get properties command Szymon Janc
2013-10-25 10:50 ` [PATCH v2 06/15] android/hal: Add support for sending create bond command Szymon Janc
2013-10-25 10:50 ` [PATCH v2 07/15] android/hal: Add support for sending cancel " Szymon Janc
2013-10-25 10:50 ` [PATCH v2 08/15] android/hal: Add support for sending adapter remove " Szymon Janc
2013-10-25 10:50 ` [PATCH v2 09/15] android/hal: Add support for sending adapter PIN reply command Szymon Janc
2013-10-25 10:50 ` [PATCH v2 10/15] android: Add missing SSP Variant definitions to IPC document Szymon Janc
2013-10-25 10:50 ` [PATCH v2 11/15] android: Add missing SSP variant definitions to IPC header Szymon Janc
2013-10-25 10:50 ` [PATCH v2 12/15] android/hal: Add support for sending adapter SSP reply command Szymon Janc
2013-10-25 10:50 ` [PATCH v2 13/15] android/hal: Add support for handling adapter properties change event Szymon Janc
2013-10-25 10:50 ` [PATCH v2 14/15] android: Add missing success status definition to IPC header Szymon Janc
2013-10-25 10:50 ` [PATCH v2 15/15] android: Add initial support for handling adapter get property command Szymon Janc
2013-10-25 12:29 ` [PATCH v2 01/15] android: Remove not needed local variable in connect_hal Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382698211-9123-1-git-send-email-szymon.janc@tieto.com \
--to=szymon.janc@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox