Linux bluetooth development
 help / color / mirror / Atom feed
From: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH] android/daemon: Solves warnings when compiling for Android
Date: Tue, 29 Oct 2013 15:29:54 +0200	[thread overview]
Message-ID: <1383053394-22664-1-git-send-email-Andrei.Emeltchenko.news@gmail.com> (raw)

From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>

When compiling for Android I get very annoying warnings shown below.
Though the issue is with android this really helps to clear Android
build screen.

external/bluetooth/bluez/android/main.c: In function 'cmd_watch_cb':
external/bluetooth/bluez/android/main.c:192:3: warning: format '%zd' expects
  argument of type 'signed size_t', but argument 2 has type 'ssize_t' [-Wformat]
external/bluetooth/bluez/android/main.c:197:3: warning: format '%zd' expects
  argument of type 'signed size_t', but argument 2 has type 'ssize_t' [-Wformat]
---
 Let me know if this solution is OK and I will change other parts as well.

 android/main.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/android/main.c b/android/main.c
index 6ff30a9..63c9eda 100644
--- a/android/main.c
+++ b/android/main.c
@@ -171,7 +171,7 @@ static gboolean cmd_watch_cb(GIOChannel *io, GIOCondition cond,
 {
 	char buf[BLUEZ_HAL_MTU];
 	struct hal_hdr *msg = (void *) buf;
-	ssize_t ret;
+	int ret;
 	int fd;
 
 	if (cond & (G_IO_NVAL | G_IO_ERR | G_IO_HUP)) {
@@ -189,12 +189,12 @@ static gboolean cmd_watch_cb(GIOChannel *io, GIOCondition cond,
 	}
 
 	if (ret < (ssize_t) sizeof(*msg)) {
-		error("HAL command too small, terminating (%zd)", ret);
+		error("HAL command too small, terminating (%d)", ret);
 		goto fail;
 	}
 
 	if (ret != (ssize_t) (sizeof(*msg) + msg->len)) {
-		error("Malformed HAL command (%zd bytes), terminating", ret);
+		error("Malformed HAL command (%d bytes), terminating", ret);
 		goto fail;
 	}
 
-- 
1.7.10.4


             reply	other threads:[~2013-10-29 13:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-29 13:29 Andrei Emeltchenko [this message]
2013-10-29 13:34 ` [PATCH] android/daemon: Solves warnings when compiling for Android Marcel Holtmann
2013-10-30  9:35   ` Andrei Emeltchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1383053394-22664-1-git-send-email-Andrei.Emeltchenko.news@gmail.com \
    --to=andrei.emeltchenko.news@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox