Linux bluetooth development
 help / color / mirror / Atom feed
From: Andre Guedes <andre.guedes@openbossa.org>
To: linux-bluetooth@vger.kernel.org
Subject: [RFC 3/5] Bluetooth: Remove link type check in hci_disconn_complete_evt()
Date: Wed, 30 Oct 2013 19:01:42 -0300	[thread overview]
Message-ID: <1383170504-16602-4-git-send-email-andre.guedes@openbossa.org> (raw)
In-Reply-To: <1383170504-16602-1-git-send-email-andre.guedes@openbossa.org>

We can safely remove the link type check from hci_disconn_complete_
evt() since this check in not required for mgmt_disconnect_failed()
and mgmt_device_disconnected() does it internally.

Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
---
 net/bluetooth/hci_event.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index 5935f74..4673cfb 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -1795,8 +1795,7 @@ static void hci_disconn_complete_evt(struct hci_dev *hdev, struct sk_buff *skb)
 	if (ev->status == 0)
 		conn->state = BT_CLOSED;
 
-	if (test_and_clear_bit(HCI_CONN_MGMT_CONNECTED, &conn->flags) &&
-	    (conn->type == ACL_LINK || conn->type == LE_LINK)) {
+	if (test_and_clear_bit(HCI_CONN_MGMT_CONNECTED, &conn->flags)) {
 		if (ev->status) {
 			mgmt_disconnect_failed(hdev, &conn->dst, conn->type,
 					       conn->dst_type, ev->status);
-- 
1.8.4


  parent reply	other threads:[~2013-10-30 22:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-30 22:01 [RFC 0/5] Disconnect complete refactoring Andre Guedes
2013-10-30 22:01 ` [RFC 1/5] Bluetooth: Check address in mgmt_disconnect_failed() Andre Guedes
2013-10-30 22:01 ` [RFC 2/5] Bluetooth: Add an extra check in mgmt_device_disconnected() Andre Guedes
2013-10-30 22:01 ` Andre Guedes [this message]
2013-10-30 22:01 ` [RFC 4/5] Bluetooth: Remove unneeded check in hci_disconn_complete_evt() Andre Guedes
2013-11-02 18:14   ` Marcel Holtmann
2013-11-04 17:15     ` Andre Guedes
2013-10-30 22:01 ` [RFC 5/5] Bluetooth: Refactor hci_disconn_complete_evt Andre Guedes
2013-11-02 18:17 ` [RFC 0/5] Disconnect complete refactoring Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1383170504-16602-4-git-send-email-andre.guedes@openbossa.org \
    --to=andre.guedes@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox