From: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCHv3 4/4] android: Fix printing not NULL terminated strings
Date: Mon, 4 Nov 2013 15:22:38 +0200 [thread overview]
Message-ID: <1383571358-4942-4-git-send-email-Andrei.Emeltchenko.news@gmail.com> (raw)
In-Reply-To: <1383571358-4942-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>
From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
Android passes not NULL terminated strings.
---
android/client/textconv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/android/client/textconv.c b/android/client/textconv.c
index 8e6bdb9..9a2f7e6 100644
--- a/android/client/textconv.c
+++ b/android/client/textconv.c
@@ -258,7 +258,8 @@ char *btproperty2str(const bt_property_t *property)
switch (property->type) {
case BT_PROPERTY_BDNAME:
case BT_PROPERTY_REMOTE_FRIENDLY_NAME:
- sprintf(p, "%s", ((bt_bdname_t *) property->val)->name);
+ snprintf(p, property->len + 1, "%s",
+ ((bt_bdname_t *) property->val)->name);
break;
case BT_PROPERTY_BDADDR:
--
1.7.10.4
next prev parent reply other threads:[~2013-11-04 13:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 10:49 [PATCHv2 1/2] android/daemon: Implement get adapter name Andrei Emeltchenko
2013-11-04 10:49 ` [PATCHv2 2/2] android/daemon: Fix setting " Andrei Emeltchenko
2013-11-04 11:17 ` [PATCHv2 1/2] android/daemon: Implement get " Luiz Augusto von Dentz
2013-11-04 12:51 ` Andrei Emeltchenko
2013-11-04 13:22 ` [PATCHv3 1/4] " Andrei Emeltchenko
2013-11-04 13:22 ` [PATCHv3 2/4] android/daemon: Clean up get_address name Andrei Emeltchenko
2013-11-04 13:22 ` [PATCHv3 3/4] android/daemon: Fix setting adapter name Andrei Emeltchenko
2013-11-04 13:22 ` Andrei Emeltchenko [this message]
2013-11-04 19:18 ` [PATCHv3 1/4] android/daemon: Implement get " Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383571358-4942-4-git-send-email-Andrei.Emeltchenko.news@gmail.com \
--to=andrei.emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox