From: Szymon Janc <szymon.janc@tieto.com>
To: Grzegorz Kolodziejczyk <grzegorz.kolodziejczyk@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 2/6] android/pan: Return correct error value
Date: Thu, 26 Feb 2015 10:31:16 +0100 [thread overview]
Message-ID: <13838013.rVrWx2AP1Y@uw000953> (raw)
In-Reply-To: <1424355399-10015-2-git-send-email-grzegorz.kolodziejczyk@tieto.com>
Hi Grzegorz,
On Thursday 19 of February 2015 15:16:35 Grzegorz Kolodziejczyk wrote:
> If problem with bt_io_listen occurs the input/output error is the most
> aproperiate error code to problem rather than invalid argument error
> code.
> ---
> android/pan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/android/pan.c b/android/pan.c
> index 3471805..972af89 100644
> --- a/android/pan.c
> +++ b/android/pan.c
> @@ -636,7 +636,7 @@ static int register_nap_server(void)
> destroy_nap_device();
> error("%s", gerr->message);
> g_error_free(gerr);
> - return -EINVAL;
> + return -EIO;
> }
>
> return 0;
>
This patch is now applied, thanks.
--
Best regards,
Szymon Janc
next prev parent reply other threads:[~2015-02-26 9:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 14:16 [PATCH 1/6] profiles/network: Minor style fix Grzegorz Kolodziejczyk
2015-02-19 14:16 ` [PATCH 2/6] android/pan: Return correct error value Grzegorz Kolodziejczyk
2015-02-26 9:31 ` Szymon Janc [this message]
2015-02-19 14:16 ` [PATCH 3/6] profiles/network: Use send ctrl rsp to unknown BNEP ctrl cmd Grzegorz Kolodziejczyk
2015-02-26 9:37 ` Szymon Janc
2015-02-26 9:39 ` Grzegorz Kolodziejczyk
2015-02-19 14:16 ` [PATCH 4/6] profiles/network: Integrate get and check bnep setup services roles Grzegorz Kolodziejczyk
2015-02-19 14:16 ` [PATCH 5/6] profiles/network: Move bnep connection setup logic to bnep Grzegorz Kolodziejczyk
2015-02-19 14:16 ` [PATCH 6/6] profiles/network: Handle ctrl rsp after conn setup by bnep Grzegorz Kolodziejczyk
2015-02-26 9:32 ` [PATCH 1/6] profiles/network: Minor style fix Szymon Janc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13838013.rVrWx2AP1Y@uw000953 \
--to=szymon.janc@tieto.com \
--cc=grzegorz.kolodziejczyk@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox