linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ravi kumar Veeramally <ravikumar.veeramally@linux.intel.com>
To: linux-bluetooth@vger.kernel.org
Cc: Ravi kumar Veeramally <ravikumar.veeramally@linux.intel.com>
Subject: [PATCH_v2 06/11] android/hid: Fill send data structure variables in hal-hidhost
Date: Fri,  8 Nov 2013 00:10:15 +0200	[thread overview]
Message-ID: <1383862220-29968-7-git-send-email-ravikumar.veeramally@linux.intel.com> (raw)
In-Reply-To: <1383862220-29968-1-git-send-email-ravikumar.veeramally@linux.intel.com>

---
 android/hal-hidhost.c | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/android/hal-hidhost.c b/android/hal-hidhost.c
index 6fe4c52..1617a16 100644
--- a/android/hal-hidhost.c
+++ b/android/hal-hidhost.c
@@ -330,7 +330,8 @@ static bt_status_t set_report(bt_bdaddr_t *bd_addr,
 
 static bt_status_t send_data(bt_bdaddr_t *bd_addr, char *data)
 {
-	struct hal_cmd_hidhost_send_data cmd;
+	struct hal_cmd_hidhost_send_data *cmd;
+	int cmd_len, status;
 
 	DBG("");
 
@@ -340,10 +341,19 @@ static bt_status_t send_data(bt_bdaddr_t *bd_addr, char *data)
 	if (!bd_addr || !data)
 		return BT_STATUS_PARM_INVALID;
 
-	memcpy(cmd.bdaddr, bd_addr, sizeof(cmd.bdaddr));
+	cmd_len = sizeof(*cmd) + sizeof(struct hal_cmd_hidhost_send_data)
+							+ 1 + strlen(data);
 
-	return hal_ipc_cmd(HAL_SERVICE_ID_HIDHOST, HAL_OP_HIDHOST_SEND_DATA,
-					sizeof(cmd), &cmd, 0, NULL, NULL);
+	cmd = malloc(cmd_len);
+	memset(cmd, 0, cmd_len);
+	memcpy(cmd->bdaddr, bd_addr, sizeof(cmd->bdaddr));
+	cmd->len = strlen(data);
+	memcpy(cmd->data, data, cmd->len);
+
+	status = hal_ipc_cmd(HAL_SERVICE_ID_HIDHOST, HAL_OP_HIDHOST_SEND_DATA,
+						cmd_len, cmd, 0, NULL, NULL);
+	free(cmd);
+	return status;
 }
 
 static bt_status_t init(bthh_callbacks_t *callbacks)
-- 
1.8.3.2


  parent reply	other threads:[~2013-11-07 22:10 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-07 22:10 [PATCH_v2 00/11] Fix issues and implement virtual unplug and send data Ravi kumar Veeramally
2013-11-07 22:10 ` [PATCH_v2 01/11] android/hid: Remove fixed number of hid set report data length in ipc doc Ravi kumar Veeramally
2013-11-07 22:10 ` [PATCH_v2 02/11] android/hid: Add a ascii2hex utility Ravi kumar Veeramally
2013-11-08  6:44   ` Jerzy Kasenberg
2013-11-08  8:10   ` Johan Hedberg
     [not found]     ` <527CA596.6070602@linux.intel.com>
2013-11-08  8:48       ` Johan Hedberg
2013-11-08  9:05         ` Ravi Kumar Veeramally
2013-11-07 22:10 ` [PATCH_v2 03/11] android/hid: Fix set report data format Ravi kumar Veeramally
2013-11-07 22:10 ` [PATCH_v2 04/11] android/hid: Add missing hid send data parameters in ipc document Ravi kumar Veeramally
2013-11-07 22:10 ` [PATCH_v2 05/11] android/hid: Add missing parameters in send data struct in HAL headers Ravi kumar Veeramally
2013-11-07 22:10 ` Ravi kumar Veeramally [this message]
2013-11-08  9:17   ` [PATCH_v2 06/11] android/hid: Fill send data structure variables in hal-hidhost Johan Hedberg
2013-11-08  9:30     ` Ravi Kumar Veeramally
2013-11-07 22:10 ` [PATCH_v2 07/11] android/hid: Rename virtual unplug define and struct Ravi kumar Veeramally
2013-11-08  9:18   ` Johan Hedberg
2013-11-07 22:10 ` [PATCH_v2 08/11] android/hid: Add hid event virtual unplug structure to HAL msg headers Ravi kumar Veeramally
2013-11-07 22:10 ` [PATCH_v2 09/11] android/hid: Handle virtual unplug notification in hid hal Ravi kumar Veeramally
2013-11-08  8:39   ` Johan Hedberg
2013-11-07 22:10 ` [PATCH_v2 10/11] android/hid: Add virtual unplug implemention in daemon Ravi kumar Veeramally
2013-11-08  8:37   ` Johan Hedberg
2013-11-07 22:10 ` [PATCH_v2 11/11] android/hid: Add send data " Ravi kumar Veeramally

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1383862220-29968-7-git-send-email-ravikumar.veeramally@linux.intel.com \
    --to=ravikumar.veeramally@linux.intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).