linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ravi kumar Veeramally <ravikumar.veeramally@linux.intel.com>
To: linux-bluetooth@vger.kernel.org
Cc: Ravi kumar Veeramally <ravikumar.veeramally@linux.intel.com>
Subject: [PATCH_v2 07/11] android/hid: Rename virtual unplug define and struct
Date: Fri,  8 Nov 2013 00:10:16 +0200	[thread overview]
Message-ID: <1383862220-29968-8-git-send-email-ravikumar.veeramally@linux.intel.com> (raw)
In-Reply-To: <1383862220-29968-1-git-send-email-ravikumar.veeramally@linux.intel.com>

Renaming virtual unplug define and strcut name from VP to more
meaning full.
---
 android/hal-hidhost.c | 5 +++--
 android/hal-msg.h     | 4 ++--
 android/hidhost.c     | 4 ++--
 3 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/android/hal-hidhost.c b/android/hal-hidhost.c
index 1617a16..dbdf176 100644
--- a/android/hal-hidhost.c
+++ b/android/hal-hidhost.c
@@ -141,7 +141,7 @@ static bt_status_t disconnect(bt_bdaddr_t *bd_addr)
 
 static bt_status_t virtual_unplug(bt_bdaddr_t *bd_addr)
 {
-	struct hal_cmd_hidhost_vp cmd;
+	struct hal_cmd_hidhost_virtual_unplug cmd;
 
 	DBG("");
 
@@ -153,7 +153,8 @@ static bt_status_t virtual_unplug(bt_bdaddr_t *bd_addr)
 
 	memcpy(cmd.bdaddr, bd_addr, sizeof(cmd.bdaddr));
 
-	return hal_ipc_cmd(HAL_SERVICE_ID_HIDHOST, HAL_OP_HIDHOST_VP,
+	return hal_ipc_cmd(HAL_SERVICE_ID_HIDHOST,
+					HAL_OP_HIDHOST_VIRTUAL_UNPLUG,
 					sizeof(cmd), &cmd, 0, NULL, NULL);
 }
 
diff --git a/android/hal-msg.h b/android/hal-msg.h
index 05c9de0..3ad9af6 100644
--- a/android/hal-msg.h
+++ b/android/hal-msg.h
@@ -242,8 +242,8 @@ struct hal_cmd_hidhost_disconnect {
 	uint8_t bdaddr[6];
 } __attribute__((packed));
 
-#define HAL_OP_HIDHOST_VP			0x03
-struct hal_cmd_hidhost_vp {
+#define HAL_OP_HIDHOST_VIRTUAL_UNPLUG		0x03
+struct hal_cmd_hidhost_virtual_unplug {
 	uint8_t bdaddr[6];
 } __attribute__((packed));
 
diff --git a/android/hidhost.c b/android/hidhost.c
index 4b12318..b7ec6ff 100644
--- a/android/hidhost.c
+++ b/android/hidhost.c
@@ -741,7 +741,7 @@ static uint8_t bt_hid_disconnect(struct hal_cmd_hidhost_disconnect *cmd,
 	return HAL_STATUS_SUCCESS;
 }
 
-static uint8_t bt_hid_virtual_unplug(struct hal_cmd_hidhost_vp *cmd,
+static uint8_t bt_hid_virtual_unplug(struct hal_cmd_hidhost_virtual_unplug *cmd,
 								uint16_t len)
 {
 	DBG("Not Implemented");
@@ -942,7 +942,7 @@ void bt_hid_handle_cmd(int sk, uint8_t opcode, void *buf, uint16_t len)
 	case HAL_OP_HIDHOST_DISCONNECT:
 		status = bt_hid_disconnect(buf, len);
 		break;
-	case HAL_OP_HIDHOST_VP:
+	case HAL_OP_HIDHOST_VIRTUAL_UNPLUG:
 		status = bt_hid_virtual_unplug(buf, len);
 		break;
 	case HAL_OP_HIDHOST_SET_INFO:
-- 
1.8.3.2


  parent reply	other threads:[~2013-11-07 22:10 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-07 22:10 [PATCH_v2 00/11] Fix issues and implement virtual unplug and send data Ravi kumar Veeramally
2013-11-07 22:10 ` [PATCH_v2 01/11] android/hid: Remove fixed number of hid set report data length in ipc doc Ravi kumar Veeramally
2013-11-07 22:10 ` [PATCH_v2 02/11] android/hid: Add a ascii2hex utility Ravi kumar Veeramally
2013-11-08  6:44   ` Jerzy Kasenberg
2013-11-08  8:10   ` Johan Hedberg
     [not found]     ` <527CA596.6070602@linux.intel.com>
2013-11-08  8:48       ` Johan Hedberg
2013-11-08  9:05         ` Ravi Kumar Veeramally
2013-11-07 22:10 ` [PATCH_v2 03/11] android/hid: Fix set report data format Ravi kumar Veeramally
2013-11-07 22:10 ` [PATCH_v2 04/11] android/hid: Add missing hid send data parameters in ipc document Ravi kumar Veeramally
2013-11-07 22:10 ` [PATCH_v2 05/11] android/hid: Add missing parameters in send data struct in HAL headers Ravi kumar Veeramally
2013-11-07 22:10 ` [PATCH_v2 06/11] android/hid: Fill send data structure variables in hal-hidhost Ravi kumar Veeramally
2013-11-08  9:17   ` Johan Hedberg
2013-11-08  9:30     ` Ravi Kumar Veeramally
2013-11-07 22:10 ` Ravi kumar Veeramally [this message]
2013-11-08  9:18   ` [PATCH_v2 07/11] android/hid: Rename virtual unplug define and struct Johan Hedberg
2013-11-07 22:10 ` [PATCH_v2 08/11] android/hid: Add hid event virtual unplug structure to HAL msg headers Ravi kumar Veeramally
2013-11-07 22:10 ` [PATCH_v2 09/11] android/hid: Handle virtual unplug notification in hid hal Ravi kumar Veeramally
2013-11-08  8:39   ` Johan Hedberg
2013-11-07 22:10 ` [PATCH_v2 10/11] android/hid: Add virtual unplug implemention in daemon Ravi kumar Veeramally
2013-11-08  8:37   ` Johan Hedberg
2013-11-07 22:10 ` [PATCH_v2 11/11] android/hid: Add send data " Ravi kumar Veeramally

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1383862220-29968-8-git-send-email-ravikumar.veeramally@linux.intel.com \
    --to=ravikumar.veeramally@linux.intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).