From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cyrus@holtmann.org>
Message-ID: <1384421473.2229.1.camel@nuvo>
Subject: Re: Adapter name reset on suspend/resume
From: Bastien Nocera <hadess@hadess.net>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: "linux-bluetooth@vger.kernel.org development"
	 <linux-bluetooth@vger.kernel.org>
Date: Thu, 14 Nov 2013 10:31:13 +0100
In-Reply-To: <130CE89B-A508-4FB9-B7EA-35D500742EC1@holtmann.org>
References: <1384350278.5071.6.camel@nuvo>
	 <130CE89B-A508-4FB9-B7EA-35D500742EC1@holtmann.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
List-ID: <linux-bluetooth.vger.kernel.org>

On Thu, 2013-11-14 at 08:28 +0900, Marcel Holtmann wrote:
> Hi Bastien,
> 
> > After suspending and resuming my laptop, hci0's name is reset to what
> > looks like the factory name:
> > $ hciconfig -a | grep Name
> > 	Name: 'BCM20702A'
> > 
> > This is the device in question:
> > Bus 001 Device 004: ID 0a5c:21e6 Broadcom Corp. BCM20702 Bluetooth 4.0 [ThinkPad]
> > 
> > And my laptop is a Lenovo X1 Carbon.
> > 
> > Neither udevadm nor btmon show the device going away on suspend and
> > coming back on resume.
> 
> can you start btmon, call hciconfig hci0 name, then suspend, then
> resume, call hciconfig hci0 name again.

Bluetooth monitor ver 5.10
= New Index: F4:B7:E2:E8:99:E2 (BR/EDR,USB,hci0)                   [hci0] 0.176335
< HCI Command: Read Local Name (0x03|0x0014) plen 0                [hci0] 9.797930
> HCI Event: Command Complete (0x0e) plen 252                      [hci0] 9.813834
      Read Local Name (0x03|0x0014) ncmd 1
        Status: Success (0x00)
        Name: nuvo
< HCI Command: Read Local Name (0x03|0x0014) plen 0               [hci0] 33.109166
> HCI Event: Command Complete (0x0e) plen 252                     [hci0] 33.125157
      Read Local Name (0x03|0x0014) ncmd 1
        Status: Success (0x00)
        Name: BCM20702A

> I am wondering if for some reason the suspend/resume actually does a
> HCI Reset without telling us. The name normally only gets reset to
> BCM20702A when doing a full reset.

Looks like that's what it's doing.

> Another possibility is that we actually forgot to set it in the first
> place. I am pretty sure I have intensively tested and that should not
> happen, but you might just found a corner case.

It's set on a normal boot, it seems to be reset only when suspending.

Cheers