Linux bluetooth development
 help / color / mirror / Atom feed
From: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH 1/6] android/socket: Make profile struct const
Date: Tue, 26 Nov 2013 16:05:45 +0200	[thread overview]
Message-ID: <1385474750-18331-1-git-send-email-Andrei.Emeltchenko.news@gmail.com> (raw)

From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>

We are not supposed to change profile structure, make it const.
---
 android/socket.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/android/socket.c b/android/socket.c
index 83e6996..184deae 100644
--- a/android/socket.c
+++ b/android/socket.c
@@ -335,7 +335,7 @@ static sdp_record_t *create_spp_record(uint8_t chan, const char *svc_name)
 	return record;
 }
 
-static struct profile_info {
+static const struct profile_info {
 	uint8_t		uuid[16];
 	uint8_t		channel;
 	uint8_t		svc_hint;
@@ -381,7 +381,7 @@ static struct profile_info {
 	},
 };
 
-static uint32_t sdp_service_register(struct profile_info *profile,
+static uint32_t sdp_service_register(const struct profile_info *profile,
 							const void *svc_name)
 {
 	sdp_record_t *record;
@@ -444,7 +444,7 @@ static int bt_sock_send_fd(int sock_fd, const void *buf, int len, int send_fd)
 	return ret;
 }
 
-static struct profile_info *get_profile_by_uuid(const uint8_t *uuid)
+static const struct profile_info *get_profile_by_uuid(const uint8_t *uuid)
 {
 	unsigned int i;
 
@@ -651,7 +651,7 @@ static void accept_cb(GIOChannel *io, GError *err, gpointer user_data)
 static int handle_listen(void *buf)
 {
 	struct hal_cmd_sock_listen *cmd = buf;
-	struct profile_info *profile;
+	const struct profile_info *profile;
 	struct rfcomm_sock *rfsock;
 	BtIOSecLevel sec_level;
 	GIOChannel *io;
-- 
1.8.3.2


             reply	other threads:[~2013-11-26 14:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-26 14:05 Andrei Emeltchenko [this message]
2013-11-26 14:05 ` [PATCH 2/6] android/socket: Use security level for connect / listen Andrei Emeltchenko
2013-11-26 14:05 ` [PATCH 3/6] android/socket: Handle Android events for server socket Andrei Emeltchenko
2013-11-26 15:46   ` Johan Hedberg
2013-11-27  8:00     ` Andrei Emeltchenko
2013-11-27  8:21       ` Johan Hedberg
2013-11-27  8:29         ` Andrei Emeltchenko
2013-11-27  9:03           ` Johan Hedberg
2013-11-26 14:05 ` [PATCH 4/6] android/socket: Check create_rfsock returns valid structure Andrei Emeltchenko
2013-11-27 10:55   ` Johan Hedberg
2013-11-26 14:05 ` [PATCH 5/6] android/hal-sock: Check uuid before dereference Andrei Emeltchenko
2013-11-27 10:54   ` Johan Hedberg
2013-11-26 14:05 ` [PATCH 6/6] android: Do not dereference possible NULL pointer Andrei Emeltchenko
2013-11-27 10:52   ` Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1385474750-18331-1-git-send-email-Andrei.Emeltchenko.news@gmail.com \
    --to=andrei.emeltchenko.news@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox