Linux bluetooth development
 help / color / mirror / Atom feed
From: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH 09/10] android/socket: Avoid double close of file descriptor
Date: Thu, 28 Nov 2013 16:38:05 +0200	[thread overview]
Message-ID: <1385649486-19978-9-git-send-email-Andrei.Emeltchenko.news@gmail.com> (raw)
In-Reply-To: <1385649486-19978-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>

From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>

Since we close all file descriptors in cleanup_rfsock do not close it also
during iochannel cleaning up. The flag was setup in bt_io_listen and
bt_io_connect calls.
---
 android/socket.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/android/socket.c b/android/socket.c
index 45ff90e..8df6e01 100644
--- a/android/socket.c
+++ b/android/socket.c
@@ -641,6 +641,7 @@ static void accept_cb(GIOChannel *io, GError *err, gpointer user_data)
 	/* Handle rfcomm events */
 	cond = G_IO_IN | G_IO_HUP | G_IO_ERR | G_IO_NVAL;
 	id = g_io_add_watch(io, cond, sock_rfcomm_event_cb, rfsock_acc);
+	g_io_channel_set_close_on_unref(io, FALSE);
 
 	rfsock_acc->rfcomm_watch = id;
 
@@ -777,6 +778,7 @@ static void connect_cb(GIOChannel *io, GError *err, gpointer user_data)
 	/* Handle rfcomm events */
 	cond = G_IO_IN | G_IO_ERR | G_IO_HUP | G_IO_NVAL;
 	id = g_io_add_watch(io, cond, sock_rfcomm_event_cb, rfsock);
+	g_io_channel_set_close_on_unref(io, FALSE);
 
 	rfsock->rfcomm_watch = id;
 
-- 
1.8.3.2


  parent reply	other threads:[~2013-11-28 14:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-28 14:37 [PATCH 01/10] android: Avoid memory leak warnings for event_loop Andrei Emeltchenko
2013-11-28 14:37 ` [PATCH 02/10] android/main: Remove timeout source on exit Andrei Emeltchenko
2013-11-28 14:37 ` [PATCH 03/10] android/main: Remove signal " Andrei Emeltchenko
2013-11-28 14:38 ` [PATCH 04/10] android/main: Free enabled string " Andrei Emeltchenko
2013-11-29  8:29   ` Johan Hedberg
2013-11-28 14:38 ` [PATCH 05/10] android/socket: Cleanup sockets on unregister Andrei Emeltchenko
2013-11-29  8:26   ` Johan Hedberg
2013-11-28 14:38 ` [PATCH 06/10] android/socket: Fix rfsock lists Andrei Emeltchenko
2013-11-28 14:38 ` [PATCH 07/10] android/hidhost: Shutdown ctrl_io channel if intr_io fails Andrei Emeltchenko
2013-11-28 14:38 ` [PATCH 08/10] android/socket: Strip extra log messages Andrei Emeltchenko
2013-11-28 14:38 ` Andrei Emeltchenko [this message]
2013-11-28 14:38 ` [PATCH 10/10] android/socket: Remove unneeded code Andrei Emeltchenko
2013-11-29  8:31   ` Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1385649486-19978-9-git-send-email-Andrei.Emeltchenko.news@gmail.com \
    --to=andrei.emeltchenko.news@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox