From: Johan Hedberg <johan.hedberg@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH 10/31] Bluetooth: Refactor L2CAP connect rejection to its own function
Date: Wed, 4 Dec 2013 16:11:06 +0200 [thread overview]
Message-ID: <1386166287-13693-11-git-send-email-johan.hedberg@gmail.com> (raw)
In-Reply-To: <1386166287-13693-1-git-send-email-johan.hedberg@gmail.com>
From: Johan Hedberg <johan.hedberg@intel.com>
We'll need to have a separate code patch for LE based connection
rejection so it's cleaner to move out the response construction code
into its own function (and later a second one for LE).
Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
---
net/bluetooth/l2cap_core.c | 42 ++++++++++++++++++++++++------------------
1 file changed, 24 insertions(+), 18 deletions(-)
diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
index 256662578f89..5f9287fd86df 100644
--- a/net/bluetooth/l2cap_core.c
+++ b/net/bluetooth/l2cap_core.c
@@ -617,6 +617,27 @@ void l2cap_chan_del(struct l2cap_chan *chan, int err)
return;
}
+static void l2cap_chan_connect_reject(struct l2cap_chan *chan)
+{
+ struct l2cap_conn *conn = chan->conn;
+ struct l2cap_conn_rsp rsp;
+ u16 result;
+
+ if (test_bit(FLAG_DEFER_SETUP, &chan->flags))
+ result = L2CAP_CR_SEC_BLOCK;
+ else
+ result = L2CAP_CR_BAD_PSM;
+
+ l2cap_state_change(chan, BT_DISCONN);
+
+ rsp.scid = cpu_to_le16(chan->dcid);
+ rsp.dcid = cpu_to_le16(chan->scid);
+ rsp.result = cpu_to_le16(result);
+ rsp.status = __constant_cpu_to_le16(L2CAP_CS_NO_INFO);
+
+ l2cap_send_cmd(conn, chan->ident, L2CAP_CONN_RSP, sizeof(rsp), &rsp);
+}
+
void l2cap_chan_close(struct l2cap_chan *chan, int reason)
{
struct l2cap_conn *conn = chan->conn;
@@ -639,24 +660,9 @@ void l2cap_chan_close(struct l2cap_chan *chan, int reason)
break;
case BT_CONNECT2:
- if (chan->chan_type == L2CAP_CHAN_CONN_ORIENTED &&
- conn->hcon->type == ACL_LINK) {
- struct l2cap_conn_rsp rsp;
- __u16 result;
-
- if (test_bit(FLAG_DEFER_SETUP, &chan->flags))
- result = L2CAP_CR_SEC_BLOCK;
- else
- result = L2CAP_CR_BAD_PSM;
-
- l2cap_state_change(chan, BT_DISCONN);
-
- rsp.scid = cpu_to_le16(chan->dcid);
- rsp.dcid = cpu_to_le16(chan->scid);
- rsp.result = cpu_to_le16(result);
- rsp.status = __constant_cpu_to_le16(L2CAP_CS_NO_INFO);
- l2cap_send_cmd(conn, chan->ident, L2CAP_CONN_RSP,
- sizeof(rsp), &rsp);
+ if (chan->chan_type == L2CAP_CHAN_CONN_ORIENTED) {
+ if (conn->hcon->type == ACL_LINK)
+ l2cap_chan_connect_reject(chan);
}
l2cap_chan_del(chan, reason);
--
1.8.4.2
next prev parent reply other threads:[~2013-12-04 14:11 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 14:10 [PATCH 00/31] Bluetooth: LE CoC support Johan Hedberg
2013-12-04 14:10 ` [PATCH 01/31] Bluetooth: Remove unnecessary braces from one-line if-statement Johan Hedberg
2013-12-04 14:10 ` [PATCH 02/31] Bluetooth: Add module parameter to enable LE CoC support Johan Hedberg
2013-12-04 14:10 ` [PATCH 03/31] Bluetooth: Update l2cap_global_chan_by_psm() to take a link type Johan Hedberg
2013-12-04 14:11 ` [PATCH 04/31] Bluetooth: Allow l2cap_chan_check_security() to be used for LE links Johan Hedberg
2013-12-04 14:11 ` [PATCH 05/31] Bluetooth: Pass command length to LE signaling channel handlers Johan Hedberg
2013-12-04 14:11 ` [PATCH 06/31] Bluetooth: Move LE L2CAP initiator procedure to its own function Johan Hedberg
2013-12-04 14:11 ` [PATCH 07/31] Bluetooth: Add definitions for LE connection oriented channels Johan Hedberg
2013-12-04 14:11 ` [PATCH 08/31] Bluetooth: Add initial code for LE L2CAP Connect Request Johan Hedberg
2013-12-04 14:11 ` [PATCH 09/31] Bluetooth: Add smp_sufficient_security helper function Johan Hedberg
2013-12-04 14:11 ` Johan Hedberg [this message]
2013-12-04 16:14 ` [PATCH 10/31] Bluetooth: Refactor L2CAP connect rejection to its own function Vinicius Costa Gomes
2013-12-04 14:11 ` [PATCH 11/31] Bluetooth: Add basic LE L2CAP connect request receiving support Johan Hedberg
2013-12-04 14:11 ` [PATCH 12/31] Bluetooth: Fix L2CAP channel closing for LE connections Johan Hedberg
2013-12-04 14:11 ` [PATCH 13/31] Bluetooth: Add L2CAP Disconnect suppport for LE Johan Hedberg
2013-12-04 14:11 ` [PATCH 14/31] Bluetooth: Make l2cap_le_sig_cmd logic consistent Johan Hedberg
2013-12-04 14:11 ` [PATCH 15/31] Bluetooth: Add LE L2CAP flow control mode Johan Hedberg
2013-12-04 14:11 ` [PATCH 16/31] Bluetooth: Track LE L2CAP credits in l2cap_chan Johan Hedberg
2013-12-04 14:11 ` [PATCH 17/31] Bluetooth: Limit L2CAP_OPTIONS socket option usage with LE Johan Hedberg
2013-12-04 14:11 ` [PATCH 18/31] Bluetooth: Add new BT_SNDMTU and BT_RCVMTU socket options Johan Hedberg
2013-12-04 14:11 ` [PATCH 19/31] Bluetooth: Implement returning of LE L2CAP credits Johan Hedberg
2013-12-04 16:15 ` Vinicius Costa Gomes
2013-12-04 14:11 ` [PATCH 20/31] Bluetooth: Add LE flow control discipline Johan Hedberg
2013-12-04 14:11 ` [PATCH 21/31] Bluetooth: Reject LE CoC commands when the feature is not enabled Johan Hedberg
2013-12-04 14:11 ` [PATCH 22/31] Bluetooth: Introduce L2CAP channel callback for suspending Johan Hedberg
2013-12-04 14:11 ` [PATCH 23/31] Bluetooth: Add LE L2CAP segmentation support for outgoing data Johan Hedberg
2013-12-04 14:11 ` [PATCH 24/31] Bluetooth: Implement LE L2CAP reassembly Johan Hedberg
2013-12-04 14:11 ` [PATCH 25/31] Bluetooth: Fix LE L2CAP Connect Request handling together with SMP Johan Hedberg
2013-12-04 14:11 ` [PATCH 26/31] Bluetooth: Fix suspending the L2CAP socket if we start with 0 credits Johan Hedberg
2013-12-04 14:11 ` [PATCH 27/31] Bluetooth: Limit LE MPS to the MTU value Johan Hedberg
2013-12-04 14:11 ` [PATCH 28/31] Bluetooth: Fix clearing of chan->omtu for LE CoC channels Johan Hedberg
2013-12-04 14:11 ` [PATCH 29/31] Bluetooth: Fix CID ranges for LE CoC CID allocations Johan Hedberg
2013-12-04 14:11 ` [PATCH 30/31] Bluetooth: Fix validating LE PSM values Johan Hedberg
2013-12-04 14:11 ` [PATCH 31/31] Bluetooth: Add debugfs controls for LE CoC MPS and Credits Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386166287-13693-11-git-send-email-johan.hedberg@gmail.com \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).