From: Bastien Nocera <hadess@hadess.net>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCHv2] Fix eir parsing function.
Date: Tue, 10 Dec 2013 09:24:03 +0100 [thread overview]
Message-ID: <1386663843.1982.5.camel@nuvo> (raw)
In-Reply-To: <1386663340-12730-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>
On Tue, 2013-12-10 at 10:15 +0200, Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>
> Currently eir_parse always return 0 but it is checked throughout the code
> (in android/bluetooth code as well in src/adapteri, etc) for return value
^
typo?
> (err < 0) which never happens. Make function eir_parse return void. This
> fixes warnings from static analyzer tools.
next prev parent reply other threads:[~2013-12-10 8:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-29 8:00 [RFC] Fix eir parsing function Andrei Emeltchenko
2013-11-29 8:22 ` Johan Hedberg
2013-11-29 8:39 ` Szymon Janc
2013-11-29 8:54 ` Johan Hedberg
2013-11-29 9:03 ` Szymon Janc
2013-12-10 8:15 ` [PATCHv2] " Andrei Emeltchenko
2013-12-10 8:24 ` Bastien Nocera [this message]
2013-12-10 8:33 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386663843.1982.5.camel@nuvo \
--to=hadess@hadess.net \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).