From: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH 8/8] android/hal-sock: Fix returning incorrect error code
Date: Thu, 12 Dec 2013 17:17:54 +0200 [thread overview]
Message-ID: <1386861474-29524-8-git-send-email-Andrei.Emeltchenko.news@gmail.com> (raw)
In-Reply-To: <1386861474-29524-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>
From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
For socket type 0 we shall return BT_STATUS_PARM_INVALID.
---
android/hal-sock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/android/hal-sock.c b/android/hal-sock.c
index 301c77f..c39ca6a 100644
--- a/android/hal-sock.c
+++ b/android/hal-sock.c
@@ -81,7 +81,7 @@ static bt_status_t sock_connect(const bt_bdaddr_t *bdaddr, btsock_type_t type,
{
struct hal_cmd_sock_connect cmd;
- if ((!uuid && chan <= 0) || !bdaddr || !sock) {
+ if ((!uuid && chan <= 0) || !bdaddr || !sock || !type) {
error("Invalid params: bd_addr %s, uuid %s, chan %d, sock %p",
bdaddr2str(bdaddr), btuuid2str(uuid), chan, sock);
return BT_STATUS_PARM_INVALID;
--
1.8.3.2
next prev parent reply other threads:[~2013-12-12 15:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 15:17 [PATCH 1/8] android/tester: Add Socket test invalid params: chan and uuid Andrei Emeltchenko
2013-12-12 15:17 ` [PATCH 2/8] android/tester: Check that fd is valid for Success case Andrei Emeltchenko
2013-12-12 15:17 ` [PATCH 3/8] android/tester: trivial: Make test cases prints look nice Andrei Emeltchenko
2013-12-12 15:17 ` [PATCH 4/8] android/tester: Add Socket test success with valid fd Andrei Emeltchenko
2013-12-12 15:17 ` [PATCH 5/8] android/socket: Do not close fd on unref Andrei Emeltchenko
2013-12-13 14:39 ` Johan Hedberg
2013-12-12 15:17 ` [PATCH 6/8] android/tester: Add Socket test connect() invalid sock_type Andrei Emeltchenko
2013-12-12 15:17 ` [PATCH 7/8] android/tester: Add Socket test connect invalid sock_type L2CAP Andrei Emeltchenko
2013-12-12 15:17 ` Andrei Emeltchenko [this message]
2013-12-13 14:45 ` [PATCH 1/8] android/tester: Add Socket test invalid params: chan and uuid Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386861474-29524-8-git-send-email-Andrei.Emeltchenko.news@gmail.com \
--to=andrei.emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).